380 lines
14 KiB
Python
380 lines
14 KiB
Python
"""Mutation fixtures are synthetic; real source/API comparisons are separate."""
|
|
|
|
import json
|
|
from copy import deepcopy
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from calliope.comfyui.serialization_reference import PREVIEW_PROFILE
|
|
from calliope.comfyui.ui2api import convert, convert_reference
|
|
|
|
|
|
def real(case):
|
|
repo = Path(__file__).resolve().parents[2]
|
|
cases = json.loads((repo / "docs/hel-892/golden-cases.json").read_text())["cases"]
|
|
row = next(c for c in cases if c["id"] == case)
|
|
return json.loads((repo / row["source_path"]).read_text())
|
|
|
|
|
|
PROFILE = "comfy-frontend-1.53.6-promoted-reference"
|
|
D = "aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee"
|
|
E = "aaaaaaaa-bbbb-cccc-dddd-ffffffffffff"
|
|
|
|
|
|
def fixture(value="external", *, boolean=False):
|
|
kind = "BOOLEAN" if boolean else "STRING"
|
|
ct = "PrimitiveBoolean" if boolean else "PrimitiveStringMultiline"
|
|
definition = {
|
|
"id": D,
|
|
"inputNode": {"id": -10},
|
|
"outputNode": {"id": -20},
|
|
"inputs": [{"name": "stable", "type": kind, "linkIds": [10]}],
|
|
"outputs": [{"name": "out", "type": kind, "linkIds": [11]}],
|
|
"nodes": [
|
|
{
|
|
"id": 3,
|
|
"type": ct,
|
|
"properties": {"cnr_id": "comfy-core", "ver": "0.38.0"},
|
|
"widgets_values": [True if boolean else "internal"],
|
|
"inputs": [
|
|
{"name": "value", "type": kind, "widget": {"name": "value"}, "link": 10}
|
|
],
|
|
"outputs": [{"type": kind, "links": [11]}],
|
|
}
|
|
],
|
|
"links": [[10, -10, 0, 3, 0, kind], [11, 3, 0, -20, 0, kind]],
|
|
}
|
|
return {
|
|
"nodes": [
|
|
{
|
|
"id": 5,
|
|
"type": D,
|
|
"widgets_values": [value],
|
|
"inputs": [
|
|
{
|
|
"name": "stable",
|
|
"label": "value",
|
|
"type": kind,
|
|
"widget": {"name": "stable"},
|
|
"link": None,
|
|
}
|
|
],
|
|
"outputs": [{"name": "out", "type": kind, "links": []}],
|
|
}
|
|
],
|
|
"links": [],
|
|
"definitions": {"subgraphs": [definition]},
|
|
"extra": {"frontendVersion": "1.53.6"},
|
|
}
|
|
|
|
|
|
def test_real_preview_candidate_keeps_all_proven_serializer_differences():
|
|
source = real("02")
|
|
before = deepcopy(source)
|
|
result = convert_reference(source, PREVIEW_PROFILE)
|
|
assert result.prompt is not None and result.reference_only
|
|
for nid in ("1", "2", "3", "4"):
|
|
assert result.prompt[nid]["inputs"]["preview"] == ""
|
|
assert result.prompt[nid]["inputs"]["previewMode"] is None
|
|
assert result.prompt[nid]["inputs"]["source"][0] == "9"
|
|
assert result.prompt["6"]["inputs"]["audioUI"] == ""
|
|
assert "normalize_text" not in result.prompt["9"]["inputs"]
|
|
assert "7" not in result.prompt and source == before
|
|
assert convert(source).prompt is None
|
|
|
|
|
|
@pytest.mark.parametrize("value", [True, False, None])
|
|
def test_preview_first_persisted_element_restores_mode_not_a_dom_text(value):
|
|
source = real("02")
|
|
source["nodes"][0]["widgets_values"][0] = value
|
|
result = convert_reference(source, PREVIEW_PROFILE)
|
|
assert result.prompt["2"]["inputs"]["previewMode"] is value
|
|
assert result.prompt["2"]["inputs"]["preview"] == ""
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"mutation",
|
|
[
|
|
"count",
|
|
"bad_mode_type",
|
|
"bad_placeholder",
|
|
"provider",
|
|
"version",
|
|
"frontend",
|
|
"missing_frontend",
|
|
"custom",
|
|
"port",
|
|
],
|
|
)
|
|
def test_preview_unknown_contract_fails_entire_graph(mutation):
|
|
source = real("02")
|
|
node = source["nodes"][0]
|
|
if mutation == "count":
|
|
node["widgets_values"].pop()
|
|
elif mutation == "bad_mode_type":
|
|
node["widgets_values"][0] = 0
|
|
elif mutation == "bad_placeholder":
|
|
node["widgets_values"][1] = "saved text"
|
|
elif mutation == "provider":
|
|
node["properties"]["cnr_id"] = "override"
|
|
elif mutation == "version":
|
|
node["properties"]["ver"] = "0.38.0"
|
|
elif mutation == "frontend":
|
|
source["extra"]["frontendVersion"] = "1.53.6"
|
|
elif mutation == "missing_frontend":
|
|
source["extra"].pop("frontendVersion")
|
|
elif mutation == "custom":
|
|
node["serializeValue"] = "override"
|
|
else:
|
|
node["inputs"][0]["name"] = "other"
|
|
assert convert_reference(source, PREVIEW_PROFILE).prompt is None
|
|
|
|
|
|
@pytest.mark.parametrize("value,boolean", [("changed", False), ("", False), (False, True)])
|
|
def test_promoted_wins_over_internal_value_and_keeps_exact_scalar(value, boolean):
|
|
source = fixture(value, boolean=boolean)
|
|
before = deepcopy(source)
|
|
result = convert_reference(source, PROFILE)
|
|
assert result.prompt["5:3"]["inputs"]["value"] == value
|
|
assert type(result.prompt["5:3"]["inputs"]["value"]) is type(value)
|
|
row = result.resolved_boundaries[0]
|
|
assert row["value_pointer"] == "/nodes/0/widgets_values/0"
|
|
assert row["binding_name"] == "stable"
|
|
assert row["target_pointer"] == "/definitions/subgraphs/0/nodes/0/inputs/0"
|
|
assert source == before and convert(source).prompt is None
|
|
|
|
|
|
def test_zero_and_boolean_are_not_conflated():
|
|
source = fixture(0)
|
|
inner = source["definitions"]["subgraphs"][0]["nodes"][0]
|
|
inner.update(type="EmptyLatentImage", widgets_values=[64, 64, 1])
|
|
inner["inputs"][0].update(name="width", type="INT", widget={"name": "width"})
|
|
inner["outputs"][0]["type"] = "LATENT"
|
|
definition = source["definitions"]["subgraphs"][0]
|
|
definition["inputs"][0]["type"] = "INT"
|
|
definition["outputs"][0]["type"] = "LATENT"
|
|
definition["links"][0][5] = "INT"
|
|
definition["links"][1][5] = "LATENT"
|
|
source["nodes"][0]["inputs"][0]["type"] = "INT"
|
|
source["nodes"][0]["outputs"][0]["type"] = "LATENT"
|
|
assert convert_reference(source, PROFILE).prompt["5:3"]["inputs"]["width"] == 0
|
|
source["nodes"][0]["widgets_values"] = [False]
|
|
assert convert_reference(source, PROFILE).prompt is None
|
|
|
|
|
|
def test_external_link_has_priority_over_both_host_and_internal_scalars():
|
|
source = fixture("host")
|
|
inner = deepcopy(source["definitions"]["subgraphs"][0]["nodes"][0])
|
|
inner.update(id=9, widgets_values=["upstream"], inputs=[])
|
|
inner["outputs"][0]["links"] = [1]
|
|
source["nodes"].append(inner)
|
|
source["nodes"][0]["inputs"][0]["link"] = 1
|
|
source["links"] = [[1, 9, 0, 5, 0, "STRING"]]
|
|
result = convert_reference(source, PROFILE)
|
|
assert result.prompt["5:3"]["inputs"]["value"] == ["9", 0]
|
|
assert result.resolved_boundaries == []
|
|
|
|
|
|
def test_multi_instance_and_nested_boundary_values_do_not_cross_scopes():
|
|
source = fixture("left")
|
|
other = deepcopy(source["nodes"][0])
|
|
other.update(id=6, widgets_values=["right"])
|
|
source["nodes"].append(other)
|
|
outer = source["definitions"]["subgraphs"][0]
|
|
nested = deepcopy(outer)
|
|
nested["id"] = E
|
|
outer["nodes"] = [
|
|
{
|
|
"id": 3,
|
|
"type": E,
|
|
"widgets_values": ["nested-default"],
|
|
"inputs": [
|
|
{"name": "stable", "type": "STRING", "widget": {"name": "stable"}, "link": 10}
|
|
],
|
|
"outputs": [{"name": "out", "type": "STRING", "links": [11]}],
|
|
}
|
|
]
|
|
source["definitions"]["subgraphs"].append(nested)
|
|
result = convert_reference(source, PROFILE)
|
|
assert result.prompt["5:3:3"]["inputs"]["value"] == "left"
|
|
assert result.prompt["6:3:3"]["inputs"]["value"] == "right"
|
|
source["nodes"][1]["widgets_values"][0] = "mutated"
|
|
second = convert_reference(source, PROFILE)
|
|
assert second.prompt["5:3:3"]["inputs"]["value"] == "left"
|
|
assert second.prompt["6:3:3"]["inputs"]["value"] == "mutated"
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"mutation",
|
|
[
|
|
"null",
|
|
"missing",
|
|
"extra",
|
|
"binding",
|
|
"duplicate",
|
|
"version",
|
|
"provider",
|
|
"named_conflict",
|
|
"quarantine",
|
|
"host_custom",
|
|
"unknown",
|
|
],
|
|
)
|
|
def test_bad_promoted_contract_never_falls_back_to_internal_default(mutation):
|
|
source = fixture()
|
|
instance = source["nodes"][0]
|
|
inner = source["definitions"]["subgraphs"][0]["nodes"][0]
|
|
if mutation == "null":
|
|
instance["widgets_values"] = [None]
|
|
elif mutation == "missing":
|
|
instance["widgets_values"] = []
|
|
elif mutation == "extra":
|
|
instance["widgets_values"].append("extra")
|
|
elif mutation == "binding":
|
|
instance["inputs"][0]["widget"]["name"] = "value"
|
|
elif mutation == "duplicate":
|
|
inner["inputs"].append(deepcopy(inner["inputs"][0]))
|
|
elif mutation == "version":
|
|
inner["properties"]["ver"] = "0.31.0"
|
|
elif mutation == "provider":
|
|
inner["properties"]["cnr_id"] = "third-party"
|
|
elif mutation == "named_conflict":
|
|
instance["widgets_values_named"] = {"stable": "different"}
|
|
elif mutation == "host_custom":
|
|
instance["widgets"] = [{"name": "stable", "serializeValue": "override"}]
|
|
elif mutation == "quarantine":
|
|
instance["properties"] = {"proxyWidgetErrorQuarantine": [{"hostValue": "override"}]}
|
|
else:
|
|
inner["type"] = "Unknown"
|
|
assert convert_reference(source, PROFILE).prompt is None
|
|
|
|
|
|
def test_same_binding_fanout_and_type_constraint_conflict():
|
|
source = fixture("fanout")
|
|
d = source["definitions"]["subgraphs"][0]
|
|
other = deepcopy(d["nodes"][0])
|
|
other["id"] = 4
|
|
other["inputs"][0]["link"] = 12
|
|
other["outputs"][0]["links"] = []
|
|
d["nodes"].append(other)
|
|
d["inputs"][0]["linkIds"].append(12)
|
|
d["links"].append([12, -10, 0, 4, 0, "STRING"])
|
|
result = convert_reference(source, PROFILE)
|
|
assert result.prompt["5:3"]["inputs"]["value"] == "fanout"
|
|
assert result.prompt["5:4"]["inputs"]["value"] == "fanout"
|
|
other["type"] = "PrimitiveBoolean"
|
|
other["inputs"][0]["type"] = "BOOLEAN"
|
|
other["outputs"][0]["type"] = "BOOLEAN"
|
|
other["widgets_values"] = [True]
|
|
assert convert_reference(source, PROFILE).prompt is None
|
|
|
|
|
|
def test_real04_resolves_proven_boundaries_without_completing_unknown_nodes():
|
|
source = real("04")
|
|
result = convert_reference(source, PROFILE)
|
|
assert result.prompt is None
|
|
values = {(v["node_id"], v["input_name"]): v for v in result.resolved_boundaries}
|
|
assert values["459:474", "switch"]["value"] is True
|
|
assert values["459:471", "thinking"]["value"] is False
|
|
assert {(v["node_id"], v["input_name"]) for v in result.unresolved_boundaries} == {
|
|
("459:458", "seed"),
|
|
("459:471", "sampling_mode.seed"),
|
|
}
|
|
# Change both representations: setting namedValuesRestore is deliberately unknown.
|
|
instance = source["nodes"][1]
|
|
instance["widgets_values"][1] = False
|
|
instance["widgets_values_named"]["switch"] = False
|
|
changed = convert_reference(source, PROFILE)
|
|
assert (
|
|
next(
|
|
v["value"]
|
|
for v in changed.resolved_boundaries
|
|
if v["node_id"] == "459:474" and v["input_name"] == "switch"
|
|
)
|
|
is False
|
|
)
|
|
|
|
|
|
def test_real03_keeps_missing_core_version_contract_explicit():
|
|
result = convert_reference(real("03"), "comfy-frontend-1.48.7-promoted-reference")
|
|
assert result.prompt is None and result.unresolved_boundaries
|
|
assert any(i["node_id"] == "37:13" for i in result.issues)
|
|
|
|
|
|
def test_parent_boundary_does_not_overwrite_unrelated_same_name_root_field():
|
|
source = fixture("parent")
|
|
root = deepcopy(source["definitions"]["subgraphs"][0]["nodes"][0])
|
|
root.update(id=9, inputs=[], widgets_values=["root"])
|
|
root["outputs"][0]["links"] = []
|
|
source["nodes"].append(root)
|
|
result = convert_reference(source, PROFILE)
|
|
assert result.prompt["5:3"]["inputs"]["value"] == "parent"
|
|
assert result.prompt["9"]["inputs"]["value"] == "root"
|
|
|
|
|
|
def test_simple_named_restore_disagreement_rejects_and_agreement_is_safe_for_both_settings():
|
|
source = fixture("host")
|
|
inner = source["definitions"]["subgraphs"][0]["nodes"][0]
|
|
inner["widgets_values_named"] = {"value": "internal"}
|
|
source["nodes"][0]["widgets_values_named"] = {"stable": "host"}
|
|
assert convert_reference(source, PROFILE).prompt["5:3"]["inputs"]["value"] == "host"
|
|
inner["widgets_values_named"]["value"] = "other"
|
|
assert convert_reference(source, PROFILE).prompt is None
|
|
|
|
|
|
def test_promoted_link_resolution_bypasses_inner_dynamic_prompt_serializer():
|
|
source = real("04")
|
|
instance = source["nodes"][1]
|
|
names = [s["name"] for s in instance["inputs"]]
|
|
index = names.index("negative_prompt")
|
|
instance["widgets_values"][index] = "{raw|not sampled}"
|
|
instance["widgets_values_named"]["negative_prompt"] = "{raw|not sampled}"
|
|
result = convert_reference(source, PROFILE)
|
|
resolved = next(
|
|
r
|
|
for r in result.resolved_boundaries
|
|
if (r["node_id"], r["input_name"]) == ("459:452", "negative_prompt")
|
|
)
|
|
assert resolved["value"] == "{raw|not sampled}"
|
|
assert result.prompt is None # unknown whole node/dynamic serializers remain closed
|
|
|
|
|
|
def test_primitive_inside_promoted_profile_remains_a_concrete_blocker():
|
|
source = fixture()
|
|
inner = source["definitions"]["subgraphs"][0]["nodes"][0]
|
|
inner["type"] = "PrimitiveNode"
|
|
result = convert_reference(source, PROFILE)
|
|
assert result.prompt is None
|
|
assert any(i["code"] == "reference_node_unsupported" for i in result.issues)
|
|
|
|
|
|
def test_conflicting_nested_store_identity_is_not_assumed_to_be_scoped_by_execution_id():
|
|
source = fixture("outer-a")
|
|
base = source["definitions"]["subgraphs"][0]
|
|
nested_a = deepcopy(base)
|
|
nested_a["id"] = E
|
|
nested_b = deepcopy(base)
|
|
nested_b["id"] = "aaaaaaaa-bbbb-cccc-dddd-111111111111"
|
|
outer_b = deepcopy(base)
|
|
outer_b["id"] = "aaaaaaaa-bbbb-cccc-dddd-222222222222"
|
|
for outer, inner, value in ((base, nested_a, "a"), (outer_b, nested_b, "b")):
|
|
outer["nodes"] = [
|
|
{
|
|
"id": 3,
|
|
"type": inner["id"],
|
|
"widgets_values": [value],
|
|
"inputs": [
|
|
{"name": "stable", "type": "STRING", "widget": {"name": "stable"}, "link": 10}
|
|
],
|
|
"outputs": [{"name": "out", "type": "STRING", "links": [11]}],
|
|
}
|
|
]
|
|
instance_b = deepcopy(source["nodes"][0])
|
|
instance_b.update(id=6, type=outer_b["id"], widgets_values=["outer-b"])
|
|
source["nodes"].append(instance_b)
|
|
source["definitions"]["subgraphs"].extend([outer_b, nested_a, nested_b])
|
|
result = convert_reference(source, PROFILE)
|
|
assert result.prompt is None
|
|
assert any("widgetId冲突" in i["message"] for i in result.issues)
|