fix(perf): report empty PCAP observation lists as failed facts

Reject an empty observation list at citation admission before reading its
first receipt, and keep writing failed factual reports. Add the full-grader
regression reproducing the prior IndexError.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
This commit is contained in:
N0zoM1z0
2026-10-14 02:40:31 +08:00
committed by morluto
co-authored by factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> Kaoru0822
parent 8924a3a06c
commit 0f24c61196
3 changed files with 15 additions and 4 deletions
@@ -298,6 +298,16 @@ class PcapGraderWorkflowTests(unittest.TestCase):
self.assertFalse(report['factual_checks']['pcap_cited_source_supports_uri_prefix'])
self.assertFalse(report['all_factual_checks_pass'])
def test_empty_delivery_observations_write_failed_facts(self):
answer, records, reference = self.fixture()
answer['delivery_observations'] = []
answer['evidence_ids'] = []
report = self.grade(answer, records, reference)
self.assertFalse(report['factual_checks']['pcap_delivery_observations_nonempty'])
self.assertFalse(report['factual_checks']['pcap_cited_call_arguments'])
self.assertFalse(report['factual_checks']['pcap_cited_parameters'])
self.assertFalse(report['all_factual_checks_pass'])
def test_cited_view_parameters_and_call_arguments_bind_actual_requests(self):
for index in [0, 1]:
for parameters in [None, {}, {'parent_evidence_id': 'ev_' + 'f' * 64,