From 15a5e08338e96b11f9c1eaab4def96b076f2cb4b Mon Sep 17 00:00:00 2001 From: GamerDubz Date: Mon, 12 Oct 2026 00:07:33 +0200 Subject: [PATCH] fix(release): treat the plugin manifests as release-version metadata Release PRs now bump .claude-plugin/plugin.json and .codex-plugin/plugin.json, but the publication history check rejected them as post-notes product changes and the release configuration test still expected the previous extra-files list. Admit both manifests in the release-only allowlist, expect them in the Release Please configuration, and assert that each manifest version matches package.json. Co-Authored-By: Claude Opus 5.5 --- docs/releasing.md | 3 ++- scripts/lib/release-notes.mjs | 2 ++ .../conformance/releaseConfiguration.test.ts | 22 +++++++++++++++++++ 3 files changed, 26 insertions(+), 1 deletion(-) diff --git a/docs/releasing.md b/docs/releasing.md index 37a28d532..c4a81cfdd 100644 --- a/docs/releasing.md +++ b/docs/releasing.md @@ -223,7 +223,8 @@ tag remains in main's ancestry. Keep the released tag unchanged. The synchronization must include `.release-please-manifest.json`, `package.json`, both root versions in `package-lock.json`, `CHANGELOG.md`, -`server.json`, and the versioned documentation examples. Run +`server.json`, both plugin manifests (`.claude-plugin/plugin.json` and +`.codex-plugin/plugin.json`), and the versioned documentation examples. Run `npm run docs:generate`, `npm run docs:check`, and the release configuration tests against the combined tree. After the merge, verify that the released tag is an ancestor of main: diff --git a/scripts/lib/release-notes.mjs b/scripts/lib/release-notes.mjs index 1fd5edc4b..e2234b00f 100644 --- a/scripts/lib/release-notes.mjs +++ b/scripts/lib/release-notes.mjs @@ -417,6 +417,8 @@ export async function verifyInventoryHistory(run, raw, source) { "package.json", "package-lock.json", "server.json", + ".claude-plugin/plugin.json", + ".codex-plugin/plugin.json", "src/generatedPackageMetadata.ts", "docs/installation.md", `docs/releases/${inventory.version}.contributions.json`, diff --git a/tests/conformance/releaseConfiguration.test.ts b/tests/conformance/releaseConfiguration.test.ts index f28bc096d..90304079e 100644 --- a/tests/conformance/releaseConfiguration.test.ts +++ b/tests/conformance/releaseConfiguration.test.ts @@ -8,6 +8,10 @@ const readJson = async (path: string): Promise => JSON.parse(await readFile(path, "utf8")) as unknown; const versionedDocumentation = ["docs/installation.md"] as const; +const pluginManifests = [ + ".claude-plugin/plugin.json", + ".codex-plugin/plugin.json", +] as const; describe("release configuration", () => { it("keeps doctor and setup runtime support aligned with package engines", async () => { @@ -42,6 +46,11 @@ describe("release configuration", () => { path: "server.json", jsonpath: "$.packages[0].version", }, + ...pluginManifests.map((path) => ({ + type: "json", + path, + jsonpath: "$.version", + })), ], }, }, @@ -79,6 +88,19 @@ describe("release configuration", () => { expect(/^## \[([^\]]+)\]/mu.exec(changelog)?.[1]).toBe(packageJson.version); }); + it.each(pluginManifests)( + "keeps the plugin manifest %s aligned with the package version", + async (path) => { + const packageJson = (await readJson("package.json")) as { + version: string; + }; + + expect(await readJson(path)).toMatchObject({ + version: packageJson.version, + }); + }, + ); + it("keeps the npm package and MCP Registry metadata aligned", async () => { const packageJson = (await readJson("package.json")) as { name: string;