fix(javascript): preserve HTML carriage return source ranges (#1092)

* test(javascript): reproduce HTML carriage return source coordinates

Compare actual resolved and unresolved artifact graph evidence with parse5 source locations across HTML line terminators and UTF-16 columns. Exercise both public built CLI analysis commands. Tests only; production and workflows unchanged.

Signed-off-by: Rudy Celekli <rudy@gradiahq.com>

* fix(javascript): preserve HTML carriage return source ranges

Treat LF, CRLF, and bare CR as HTML line endings when projecting actual script opening-tag offsets to retained source ranges. Preserve UTF-16 column semantics and document the source-coordinate contract.

Signed-off-by: Rudy Celekli <rudy@gradiahq.com>

---------

Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This commit is contained in:
Rudy Mizrahi Celekli
2026-10-09 00:15:24 +08:00
committed by GitHub
parent e94be95c66
commit 23862af1b5
4 changed files with 152 additions and 1 deletions
@@ -4,6 +4,7 @@ import { join } from "node:path";
import { expect } from "vitest";
import { z } from "zod";
import { javascriptApplicationAnalysisResultSchema } from "../../../src/domain/javascript/javascriptApplicationAnalysis.js";
import { parseEvidence } from "../../../src/domain/evidence.js";
import { analyzeJavaScriptApplication } from "../../../src/application/javascript/JavaScriptApplicationService.js";
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
@@ -70,3 +71,45 @@ cliTest(
expect(updates.every(({ terminal }) => terminal !== true)).toBe(true);
},
);
for (const command of ["analyze-javascript-application", "analyze"]) {
cliTest(
`${command} retains HTML source ranges after a bare carriage return`,
async ({ cli }) => {
const root = await createTestTempDirectory("rea-html-coordinate-cli-");
const opening = '<script src="actual.js">';
await Promise.all([
writeFile(
join(root, "index.html"),
`<main>context</main>\r${opening}</script>`,
),
writeFile(join(root, "actual.js"), "export const actual = true;"),
]);
const output = await cli.run({ arguments: [command, root, "--json"] });
expect(output.exitCode).toBe(0);
const evidence = parseEvidence(output.json);
const result = javascriptApplicationAnalysisResultSchema.parse(
evidence.normalized_result,
);
const loads = result.graph.edges.filter(
({ relation, properties }) =>
relation === "loads" && properties.script_path === "actual.js",
);
expect(loads).toHaveLength(1);
expect(loads[0]).toMatchObject({
properties: { resolved_path: "actual.js" },
evidence: {
location: {
available: true,
value: {
kind: "source-range",
source: "index.html",
start: { line: 2, column: 0 },
end: { line: 2, column: opening.length },
},
},
},
});
},
);
}