diff --git a/bridge/mitmproxy/capture.py b/bridge/mitmproxy/capture.py index ce60593bf..412306012 100644 --- a/bridge/mitmproxy/capture.py +++ b/bridge/mitmproxy/capture.py @@ -106,7 +106,7 @@ def without_userinfo(value, base_scheme=None): while end < len(parsed_text) and parsed_text[end] not in terminators: end += 1 at = parsed_text.rfind("@", start, end) - if at <= start: + if at < start: return value parsed_offset = 0 raw_start = 0 diff --git a/bridge/mitmproxy/test_capture.py b/bridge/mitmproxy/test_capture.py index 33732db07..f0a1106b1 100644 --- a/bridge/mitmproxy/test_capture.py +++ b/bridge/mitmproxy/test_capture.py @@ -134,6 +134,11 @@ class TransportUserinfoTests(unittest.TestCase): text, _sidecar, _redactions = location(b"https://user:pw@example.test/a@b") self.assertEqual(text, "https://example.test/a@b") + def test_empty_userinfo_marker_is_removed(self): + self.assertEqual( + capture.without_userinfo("https://@host"), "https://host" + ) + def test_special_schemes_skip_leading_slashes_before_userinfo(self): for value, expected in [ (b"https://\\user:pass@host/path", b"https://\\host/path"),