refactor(tools): remove artificial analysis ceilings

This commit is contained in:
morluto
2026-09-29 16:29:23 +08:00
parent 36aeec9586
commit 2f08c7c932
202 changed files with 2314 additions and 3072 deletions
+39 -22
View File
@@ -2,13 +2,19 @@ import type { McpServer } from "@modelcontextprotocol/server";
import type { BinarySessionPort } from "../application/BinarySession.js";
import { SESSION_TOOL_CONTRACTS } from "../contracts/toolContracts.js";
import { createEvidence } from "../domain/evidence.js";
import {
createEvidence,
parseEvidence,
type Evidence,
} from "../domain/evidence.js";
import { EvidenceIntegrityError } from "../domain/errors.js";
import { err } from "../domain/result.js";
import { compareFunctions } from "../domain/functionComparison.js";
import { jsonValueSchema } from "../domain/jsonValue.js";
import type { RecordUnknownInput } from "../domain/residualUnknown.js";
import { recordDerivedEvidence } from "./recordDerivedEvidence.js";
import { recordSessionEvidenceSources } from "./sessionEvidence.js";
import { runDerivedOperation } from "./runDerivedOperation.js";
import { resolveSessionEvidenceIds } from "./sessionEvidence.js";
import { FUNCTION_COMPARISON_PROVIDER } from "./sessionToolPolicies.js";
import { toolRegistrationOptions } from "./toolRegistrationOptions.js";
import { toCallToolResult } from "./toolResult.js";
@@ -23,26 +29,31 @@ export const registerFunctionComparisonTool = (
contract.name,
toolRegistrationOptions(contract),
async (input, context) => {
const expected = {
operation: "analyze_function",
predicate: "rea.analysis",
};
const left = resolveSessionEvidenceIds(
session,
[input.left_evidence_id],
expected,
);
if (!left.ok) return toCallToolResult(left, contract);
const right = resolveSessionEvidenceIds(
session,
[input.right_evidence_id],
expected,
);
if (!right.ok) return toCallToolResult(right, contract);
const leftEvidence = left.value[0];
const rightEvidence = right.value[0];
if (leftEvidence === undefined || rightEvidence === undefined)
throw new Error("Function comparison Evidence was not resolved");
let leftEvidence: Evidence;
let rightEvidence: Evidence;
try {
leftEvidence = parseEvidence(input.left);
rightEvidence = parseEvidence(input.right);
} catch (cause: unknown) {
return toCallToolResult(
err(
new EvidenceIntegrityError(
cause instanceof Error ? cause.message : "Invalid Evidence",
),
),
contract,
);
}
if (
leftEvidence.operation !== "analyze_function" ||
rightEvidence.operation !== "analyze_function" ||
leftEvidence.predicate_type !== "rea.analysis" ||
rightEvidence.predicate_type !== "rea.analysis"
)
return toCallToolResult(
err(new EvidenceIntegrityError("Expected analyze_function Evidence")),
contract,
);
const leftIds = [leftEvidence.evidence_id];
const rightIds = [rightEvidence.evidence_id];
const computed = await runDerivedOperation(context, contract.name, () =>
@@ -50,6 +61,12 @@ export const registerFunctionComparisonTool = (
);
if (!computed.ok) return toCallToolResult(computed, contract);
const comparison = computed.value;
const recordedSources = recordSessionEvidenceSources(
(evidence) => session.recordEvidence(evidence),
[leftEvidence, rightEvidence],
);
if (!recordedSources.ok)
return toCallToolResult(recordedSources, contract);
const evidence = createEvidence(undefined, FUNCTION_COMPARISON_PROVIDER, {
predicateType: "rea.function-comparison",
operation: contract.name,