fix(reference): distinguish root access failures from invalid input

Share root filesystem failure classification between import preflight and traversal. Missing roots remain invalid selections; permission and I/O errors retain their reason and reach the CLI as execution failures. Preserve cancellation priority and expose unexpected exceptions.

Validation: compiled CLI permission regression, direct reader error details, import/traversal and unreadable-directory boundaries passed. Windows-only cases were skipped on macOS; static, architecture and documentation checks passed.
This commit is contained in:
morluto
2026-10-11 03:53:50 +08:00
parent 2014ee7d68
commit 3967cfa43e
5 changed files with 113 additions and 10 deletions
+24 -5
View File
@@ -10,6 +10,7 @@ import {
type ReferenceSourceImportError,
type ReferenceSourceImportOptions,
} from "./ReferenceSourceImportTypes.js";
import { rootFilesystemFailure } from "../reference/ReferenceSourceReaderErrors.js";
/** Validated inputs ready for filesystem traversal. */
export interface PreparedReferenceSourceImport {
@@ -27,21 +28,39 @@ const failure = (
message,
});
const isAborted = (signal?: AbortSignal): boolean => signal?.aborted === true;
const resolveRoot = async (
requestedRoot: string,
signal?: AbortSignal,
): Promise<Result<string, ReferenceSourceImportError>> => {
if (isAborted(signal))
return err(failure("cancelled", "Reference source import cancelled"));
try {
if (!(await stat(requestedRoot)).isDirectory())
const metadata = await stat(requestedRoot);
if (isAborted(signal))
return err(failure("cancelled", "Reference source import cancelled"));
if (!metadata.isDirectory())
return err(
failure("invalid-root", "Reference source root is not a directory"),
);
const canonicalRoot = await realpath(resolve(requestedRoot));
if (isAborted(signal))
return err(failure("cancelled", "Reference source import cancelled"));
return ok(canonicalRoot);
} catch (cause: unknown) {
void cause;
return err(
failure("invalid-root", "Reference source root could not be resolved"),
if (isAborted(signal))
return err(failure("cancelled", "Reference source import cancelled"));
const rootFailure = rootFilesystemFailure(
cause,
"Reference source root could not be resolved",
);
if (rootFailure === undefined) throw cause;
const message =
rootFailure.code === "invalid-root"
? "Reference source root could not be resolved"
: rootFailure.message;
return err(failure(rootFailure.code, message));
}
};
@@ -83,7 +102,7 @@ export const prepareReferenceSourceImport = async (
): Promise<
Result<PreparedReferenceSourceImport, ReferenceSourceImportError>
> => {
const root = await resolveRoot(options.root);
const root = await resolveRoot(options.root, options.signal);
if (!root.ok) return root;
try {
return ok({