fix(apple): report missing keyed archive hierarchy references (#1104)

* test(apple): qualify malformed native hierarchy references

Freeze actual Foundation/AppKit producer, single-slot positive UID mutation and real optional nil control at filesystem and compiled CLI boundaries. Preserve original raw-byte evidence and existing CI.

Signed-off-by: Rudy Celekli <rudy@gradiahq.com>

* fix(apple): report missing keyed archive hierarchy references

Preserve known hierarchy objects and links while reporting unresolved nonnil object-table references as partial coverage. Retain archived nil semantics and original byte evidence.

Signed-off-by: Rudy Celekli <rudy@gradiahq.com>

---------

Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This commit is contained in:
Rudy Mizrahi Celekli
2026-10-09 01:31:53 +08:00
committed by GitHub
parent 4bb056bbb5
commit 3b2ec69c54
6 changed files with 475 additions and 17 deletions
+28 -13
View File
@@ -65,6 +65,7 @@ export const buildInterfaceBuilderAnalysis = (input: {
let omittedObjects = 0;
let omittedConnections = 0;
let omittedGraphNodes = 0;
let omittedHierarchyReferences = 0;
for (const document of input.documents.slice(0, input.limits.max_documents)) {
const parsed = parseInterfaceBuilderRecords(document.raw);
const prefix = `ib:${document.relativePath}:`;
@@ -403,6 +404,8 @@ export const buildInterfaceBuilderAnalysis = (input: {
}
const objectsTruncated =
parsed.omittedObjects > 0 || parsed.objects.length > documentObjectCount;
const parserOmittedHierarchyReferences = parsed.omittedHierarchyReferences;
omittedHierarchyReferences += parserOmittedHierarchyReferences;
const parserOmittedConnections = parsed.omittedConnections;
const connectionsTruncated =
parserOmittedConnections > 0 ||
@@ -419,7 +422,10 @@ export const buildInterfaceBuilderAnalysis = (input: {
document_kind: document.documentKind,
object_count: parsed.objectCount,
connection_count: parsed.connections.length + parserOmittedConnections,
hierarchy_complete: parsed.hierarchy.length > 0 && !truncated,
hierarchy_complete:
parsed.hierarchy.length > 0 &&
!truncated &&
parserOmittedHierarchyReferences === 0,
});
coverage.push(
{
@@ -456,19 +462,24 @@ export const buildInterfaceBuilderAnalysis = (input: {
{
facet: `hierarchy:${document.relativePath}`,
status:
parsed.hierarchy.length === 0
? "unsupported"
: hierarchyTruncated || documentOmittedHierarchyEdges > 0
? "partial"
: "complete",
parserOmittedHierarchyReferences > 0
? "partial"
: parsed.hierarchy.length === 0
? "unsupported"
: hierarchyTruncated || documentOmittedHierarchyEdges > 0
? "partial"
: "complete",
reason:
parsed.hierarchy.length === 0
? "archive_hierarchy_not_decoded"
: hierarchyTruncated || documentOmittedHierarchyEdges > 0
? "graph_limit_reached"
: null,
parserOmittedHierarchyReferences > 0
? "archive_hierarchy_references_missing"
: parsed.hierarchy.length === 0
? "archive_hierarchy_not_decoded"
: hierarchyTruncated || documentOmittedHierarchyEdges > 0
? "graph_limit_reached"
: null,
examined: hierarchyCount,
omitted: documentOmittedHierarchyEdges,
omitted:
documentOmittedHierarchyEdges + parserOmittedHierarchyReferences,
},
{
facet: `classes:${document.relativePath}`,
@@ -514,7 +525,11 @@ export const buildInterfaceBuilderAnalysis = (input: {
nodes: [...nodes.values()],
edges,
coverage,
truncated: truncated || omittedObjects > 0 || omittedConnections > 0,
truncated:
truncated ||
omittedObjects > 0 ||
omittedConnections > 0 ||
omittedHierarchyReferences > 0,
},
limitations: [
"The graph reflects recognized Interface Builder archive fields and connections; omitted private or unrecognized archive fields remain unknown.",
@@ -45,6 +45,7 @@ export const parseInterfaceBuilderRecords = (
readonly objectCount: number;
readonly omittedObjects: number;
readonly omittedConnections: number;
readonly omittedHierarchyReferences: number;
} => {
const root = record(value);
const keyed = parseKeyedArchive(root);
@@ -114,6 +115,7 @@ export const parseInterfaceBuilderRecords = (
objectCount: objectEntries.length,
omittedObjects: Math.max(0, objectEntries.length - 20_000),
omittedConnections,
omittedHierarchyReferences: 0,
};
};
@@ -194,7 +196,8 @@ const keyedArchiveTable = (objectTable: readonly unknown[]) => {
}
return output;
};
const hierarchy = (start: unknown): unknown[] => {
const hierarchy = (start: unknown) => {
let omittedReferences = 0;
const visited = new Set<number>();
const root: unknown[] = [];
const pending: { readonly value: unknown; readonly output: unknown[] }[] = [
@@ -227,9 +230,15 @@ const keyedArchiveTable = (objectTable: readonly unknown[]) => {
const { value, output } = entry;
const uid = archiveUid(value);
if (uid !== undefined) {
// UID0 is archived nil, not a missing hierarchy object.
if (uid === 0) continue;
const target = objectTable[uid];
if (target === undefined) {
omittedReferences += 1;
continue;
}
if (visited.has(uid)) continue;
visited.add(uid);
const target = objectTable[uid];
if (Array.isArray(target)) {
for (let index = target.length - 1; index >= 0; index -= 1) {
const child = target[index];
@@ -260,7 +269,7 @@ const keyedArchiveTable = (objectTable: readonly unknown[]) => {
appendNode(record(value), undefined, output);
}
}
return root;
return { items: root, omittedReferences };
};
const archivedArrayClass = (classReference: unknown): boolean => {
const uid = archiveUid(classReference);
@@ -386,11 +395,12 @@ const parseKeyedArchive = (
return {
objects,
connections,
hierarchy,
hierarchy: hierarchy.items,
classes,
objectCount,
omittedObjects: Math.max(0, objectCount - 20_000),
omittedConnections,
omittedHierarchyReferences: hierarchy.omittedReferences,
};
};