fix(native): normalize otool line endings and strip plist JSON BOM (#533)

This commit is contained in:
morluto
2026-10-05 15:28:31 +08:00
committed by GitHub
parent 0f77ada55e
commit 3e4d4d93fd
3 changed files with 50 additions and 2 deletions
@@ -0,0 +1,36 @@
import { expect, it } from "vitest";
import { parseOtoolLoadCommands } from "../../../../src/native/parsers/otool.js";
import { parsePlistJson } from "../../../../src/native/parsers/plist.js";
import { nativeFixture } from "../../../fixtures/nativeCommands.js";
const toCrlf = (value: string): string => value.replaceAll("\n", "\r\n");
it("keeps section blocks separate under CRLF captures", async () => {
const lf = parseOtoolLoadCommands(await nativeFixture("otool-load.txt"));
const crlf = parseOtoolLoadCommands(
toCrlf(await nativeFixture("otool-load.txt")),
);
expect(crlf.segments).toMatchObject(lf.segments);
const crlfText = crlf.segments.find(({ name }) => name === "__TEXT");
expect(crlfText?.sections.length).toBeGreaterThan(0);
expect(crlfText?.sections.map(({ name }) => name)).toContain("__text");
});
it("does not leak section fields into command fields under CRLF captures", async () => {
const crlf = parseOtoolLoadCommands(
toCrlf(await nativeFixture("otool-load.txt")),
);
const segment = crlf.commands.find(
(command) => command.kind === "LC_SEGMENT_64",
);
expect(segment?.fields.sectname).toBeUndefined();
expect(segment?.fields["time stamp"]).toBeUndefined();
});
it("accepts a byte-order mark before plist JSON", () => {
const parsed = parsePlistJson(
'\uFEFF{"CFBundleIdentifier":"com.owned.fixture"}',
);
expect(parsed.bundle.identifier).toBe("com.owned.fixture");
});