Merge pull request #895 from morluto/fix/javascript-indexeddb-open-version

fix(javascript): keep storage open versions out of XHR endpoints
This commit is contained in:
Kaoru0822
2026-10-07 03:22:12 -07:00
committed by GitHub
2 changed files with 33 additions and 3 deletions
@@ -410,7 +410,7 @@ const BROWSING_CONTEXT_KEYWORDS = new Set([
* `window.open(url, "_blank")` share the callee name. A literal method must
* be an HTTP method; with a computed method, the second literal is a URL
* unless it is provably an fs flag or a browsing-context keyword, or the
* receiver is spelled as a browsing context. XHR normalizes the standard
* receiver is spelled as a browsing context or storage. XHR normalizes the standard
* methods' case; extension methods such as WebDAV `PROPFIND` are
* conventionally uppercase tokens.
*/
@@ -422,13 +422,18 @@ const xhrOpenUrl = (
const url = stringValue(urlNode);
if (url === undefined) return undefined;
const method = stringValue(methodNode);
// IndexedDB and Cache Storage `open` take a name and a version, so a
// receiver spelled as storage needs a standard HTTP method literal.
const storage = storageKind(name) !== undefined;
if (method === undefined)
return WINDOW_OPEN_CALL.test(name) ||
return storage ||
WINDOW_OPEN_CALL.test(name) ||
FS_OPEN_FLAGS.has(url) ||
BROWSING_CONTEXT_KEYWORDS.has(url.toLowerCase())
? undefined
: url;
return XHR_METHODS.has(method.toUpperCase()) || /^[A-Z][A-Z-]*$/u.test(method)
return XHR_METHODS.has(method.toUpperCase()) ||
(!storage && /^[A-Z][A-Z-]*$/u.test(method))
? url
: undefined;
};