fix(process): clarify Windows capture support and recovery (#798)

This commit is contained in:
N0zoM1z0
2026-10-07 04:20:53 +08:00
committed by GitHub
parent 911d580634
commit 50787b2faf
8 changed files with 105 additions and 11 deletions
+1 -1
View File
@@ -13,7 +13,7 @@ export const processCaptureOwnershipUnavailableReason = (
platform: NodeJS.Platform,
): string | undefined =>
platform === "win32"
? "Windows process-tree ownership and cleanup are unavailable; REA cannot verify that descendants have stopped."
? "Windows PTY process capture is unavailable because this adapter does not yet verify descendant cleanup. Use Linux (including WSL for Linux commands) or macOS. Reinstalling the PTY backend does not enable native Windows capture."
: undefined;
/** Dependencies that make the native PTY probe's host boundary testable. */
+13 -2
View File
@@ -5,6 +5,7 @@ import { captureProcessScenario } from "./ProcessHarness.js";
import { settleProcessCaptureJournal } from "./ProcessCaptureLifecycle.js";
import { processCaptureSchema } from "../domain/processCapture.js";
import { EMPTY_PROCESS_CAPTURE_EXAMPLE } from "../domain/processCapture.fixture.js";
import { projectAnalysisError } from "../domain/analysisErrorProjection.js";
it("rejects legacy replay output instead of silently discarding it", () => {
expect(
@@ -48,9 +49,19 @@ it("fails closed on Windows before resolving or launching scenario paths", async
const result = await captureProcessScenario(scenario, undefined, "win32");
expect(result.ok).toBe(false);
if (result.ok) throw new Error("expected Windows ownership refusal");
expect(result.error).toBeInstanceOf(AnalysisCapabilityUnavailableError);
if (!(result.error instanceof AnalysisCapabilityUnavailableError))
throw new Error("expected a capability-unavailable outcome");
expect(result.error).toMatchObject({
operation: "capture_process_scenario",
reason: expect.stringContaining("Windows process-tree ownership"),
reason: expect.stringContaining("Windows PTY process capture"),
});
expect(projectAnalysisError(result.error)).toMatchObject({
code: "capability_unavailable",
category: "unsupported_provider",
message: expect.stringContaining("does not yet verify descendant cleanup"),
details: {
operation: "capture_process_scenario",
reason: result.error.reason,
},
});
});
+1
View File
@@ -409,6 +409,7 @@ export const captureProcessScenario = async (
"rea-process",
"capture_process_scenario",
ownershipReason,
{ userMessage: ownershipReason },
),
);
try {