fix(workflows): retain upstream symbol coverage caveats
Keep limitations from exactly the provider observations used by a composed CLI/MCP call. Reuse the authenticated Ghidra PDB handshake owner, preserve caller options and failure identity, and deduplicate caveats without extra engine queries. Verified on actual Windows with Ghidra 12.1.4 PUBLIC, JDK21.0.12.1 and Node24.18.0, using the host where.exe and its matching Microsoft public PDB. Public CLI and MCP composed Evidence retain the referenced GUID/age and unknown PDB load state. Engine processes used two CPU affinity slots and 512MiB heaps; the CLI test needed a900s startup budget. The initial600s startup timeout is retained as performance evidence. No paired speedup or complete-symbol-coverage claim is made. Refs #2259
This commit is contained in:
@@ -42,6 +42,7 @@ import {
|
||||
workflowAnalysisProfile,
|
||||
} from "./InvestigationProviders.js";
|
||||
import {
|
||||
executeComposedWorkflow,
|
||||
createWorkflowEvidence,
|
||||
workflowSnapshotRecord,
|
||||
recordWorkflowUnknowns,
|
||||
@@ -401,18 +402,17 @@ const executeAnalysisTool = async (input: {
|
||||
tool === "trace_native_ui_action"
|
||||
) {
|
||||
const { EnhancedTools } = await import("./EnhancedTools.js");
|
||||
const result = await new EnhancedTools(session).execute(
|
||||
tool,
|
||||
input.arguments,
|
||||
signal,
|
||||
const result = await executeComposedWorkflow(session, (observed) =>
|
||||
new EnhancedTools(observed).execute(tool, input.arguments, signal),
|
||||
);
|
||||
if (!result.ok) return { output: cliError(result.error) };
|
||||
const evidence = createWorkflowEvidence({
|
||||
target: input.openedTarget,
|
||||
operation: tool,
|
||||
parameters: input.arguments,
|
||||
result: result.value,
|
||||
result: result.value.result,
|
||||
upstreamProfile: evidenceProfile,
|
||||
upstreamLimitations: result.value.limitations,
|
||||
});
|
||||
return { output: evidence, evidence };
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user