refactor(input): share schema issue error construction

This commit is contained in:
morluto
2026-10-09 00:49:30 +08:00
parent 3c157b4ec6
commit 65a6288257
19 changed files with 115 additions and 124 deletions
@@ -5,14 +5,11 @@ import {
analyzeJavaScriptApplicationInputSchema,
javascriptApplicationAnalysisResultSchema,
} from "../../domain/javascript/javascriptApplicationAnalysis.js";
import {
AnalysisInputError,
AnalysisOutputError,
} from "../../domain/analysisErrorCore.js";
import { AnalysisOutputError } from "../../domain/analysisErrorCore.js";
import { ArtifactOperationError } from "../../domain/artifactOperationError.js";
import { type AnalysisError } from "../../domain/analysisErrorBase.js";
import type { Evidence } from "../../domain/evidence.js";
import { projectInputIssues } from "../../domain/inputIssueProjection.js";
import { analysisInputErrorFromIssues } from "../../domain/inputIssueProjection.js";
import { err, ok, type Result } from "../../domain/result.js";
import { ProviderAdapterError } from "../../domain/providerAdapterError.js";
import type { ExecutionOptions } from "../AnalysisProvider.js";
@@ -30,11 +27,7 @@ export const analyzeJavaScriptApplication = async (
const parsed = analyzeJavaScriptApplicationInputSchema.safeParse(rawInput);
if (!parsed.success)
return err(
new AnalysisInputError(
OPERATION,
undefined,
projectInputIssues(parsed.error.issues, rawInput),
),
analysisInputErrorFromIssues(OPERATION, parsed.error.issues, rawInput),
);
return analyzeJavaScriptApplicationValidated(parsed.data, options);
};
@@ -6,7 +6,7 @@ import {
} from "../../domain/analysisErrorCore.js";
import { type AnalysisError } from "../../domain/analysisErrorBase.js";
import type { Evidence } from "../../domain/evidence.js";
import { projectInputIssues } from "../../domain/inputIssueProjection.js";
import { analysisInputErrorFromIssues } from "../../domain/inputIssueProjection.js";
import { compareJavaScriptApplicationVersions } from "../../domain/javascript/javascriptApplicationVersionComparison.js";
import { compareApplicationVersionsInputSchema } from "../../domain/javascript/javascriptApplicationVersionComparisonSchemas.js";
import { compareJavaScriptExportShapes } from "../../domain/javascript/javascriptExportShapeComparison.js";
@@ -35,11 +35,7 @@ export const traceApplicationFeatureEvidence = (
const parsed = traceApplicationFeatureInputSchema.safeParse(rawInput);
if (!parsed.success)
return err(
new AnalysisInputError(
operation,
undefined,
projectInputIssues(parsed.error.issues, rawInput),
),
analysisInputErrorFromIssues(operation, parsed.error.issues, rawInput),
);
return traceApplicationFeatureEvidenceValidated(parsed.data);
};
@@ -85,11 +81,7 @@ export const compareApplicationVersionsEvidence = (
const parsed = compareApplicationVersionsInputSchema.safeParse(rawInput);
if (!parsed.success)
return err(
new AnalysisInputError(
operation,
undefined,
projectInputIssues(parsed.error.issues, rawInput),
),
analysisInputErrorFromIssues(operation, parsed.error.issues, rawInput),
);
return compareApplicationVersionsEvidenceValidated(parsed.data);
};
@@ -180,11 +172,7 @@ export const compareJavaScriptExportShapesEvidence = (
const parsed = compareJavaScriptExportShapesInputSchema.safeParse(rawInput);
if (!parsed.success)
return err(
new AnalysisInputError(
operation,
undefined,
projectInputIssues(parsed.error.issues, rawInput),
),
analysisInputErrorFromIssues(operation, parsed.error.issues, rawInput),
);
return compareJavaScriptExportShapesEvidenceValidated(parsed.data);
};
@@ -235,13 +223,7 @@ const workflowFailure = (
input: unknown,
): Result<never, AnalysisError> =>
cause instanceof z.ZodError
? err(
new AnalysisInputError(
operation,
undefined,
projectInputIssues(cause.issues, input),
),
)
? err(analysisInputErrorFromIssues(operation, cause.issues, input))
: cause instanceof TypeError &&
SAFE_APPLICATION_INPUT_CONSTRAINTS.has(cause.message)
? err(
@@ -12,7 +12,7 @@ import {
javascriptRecoveryResultSchema,
} from "../../domain/javascript/javascriptRecovery.js";
import { jsonObjectSchema } from "../../domain/jsonValue.js";
import { projectInputIssues } from "../../domain/inputIssueProjection.js";
import { analysisInputErrorFromIssues } from "../../domain/inputIssueProjection.js";
import { err, ok, type Result } from "../../domain/result.js";
import type { ExecutionOptions } from "../AnalysisProvider.js";
import type { JavaScriptRecoveryPort } from "./JavaScriptRecoveryPort.js";
@@ -33,11 +33,9 @@ export class JavaScriptRecoveryService {
const parsed = javascriptRecoveryInputSchema.safeParse(input);
if (!parsed.success)
return err(
new AnalysisInputError(
OPERATION,
{ cause: parsed.error },
projectInputIssues(parsed.error.issues, input),
),
analysisInputErrorFromIssues(OPERATION, parsed.error.issues, input, {
cause: parsed.error,
}),
);
const invalidPaths = (["path", "output_directory"] as const).filter(
(field) => !isAbsolute(parsed.data[field]),
@@ -7,7 +7,7 @@ import {
} from "../../domain/analysisErrorCore.js";
import { type AnalysisError } from "../../domain/analysisErrorBase.js";
import type { Evidence } from "../../domain/evidence.js";
import { projectInputIssues } from "../../domain/inputIssueProjection.js";
import { analysisInputErrorFromIssues } from "../../domain/inputIssueProjection.js";
import { reconcileJavaScriptRuntime } from "../../domain/javascript/javascriptRuntimeReconciliation.js";
import { reconcileJavaScriptRuntimeInputSchema } from "../../domain/javascript/javascriptRuntimeReconciliationSchemas.js";
import { err, ok, type Result } from "../../domain/result.js";
@@ -22,11 +22,7 @@ export const reconcileJavaScriptRuntimeEvidence = (
const parsed = reconcileJavaScriptRuntimeInputSchema.safeParse(rawInput);
if (!parsed.success)
return err(
new AnalysisInputError(
OPERATION,
undefined,
projectInputIssues(parsed.error.issues, rawInput),
),
analysisInputErrorFromIssues(OPERATION, parsed.error.issues, rawInput),
);
return reconcileJavaScriptRuntimeEvidenceValidated(parsed.data);
};
@@ -44,11 +40,7 @@ export const reconcileJavaScriptRuntimeEvidenceValidated = (
} catch (cause: unknown) {
if (cause instanceof z.ZodError)
return err(
new AnalysisInputError(
OPERATION,
undefined,
projectInputIssues(cause.issues, parsedInput),
),
analysisInputErrorFromIssues(OPERATION, cause.issues, parsedInput),
);
if (
cause instanceof TypeError &&