fix(ghidra): preserve source failures and snapshot ownership
This commit is contained in:
@@ -110,6 +110,16 @@ After metadata edits, snapshot saves and imports remain unavailable in that
|
||||
session. Use `export_evidence_bundle` to retain the observations, close without
|
||||
`snapshot_path`, and reopen the target before importing or saving a snapshot.
|
||||
|
||||
Ghidra checks its private import copy against the artifact digest selected by
|
||||
`open_binary`. If the source changes before that copy is acquired, the query
|
||||
reports `artifact_changed` with the selected path and both digests. Reopen the
|
||||
stable target to acquire its current identity. An already imported database
|
||||
continues to describe its captured bytes even if the original path is changed
|
||||
or removed; this identity failure does not mark the Ghidra installation unavailable.
|
||||
On Linux and macOS, an unreadable source reports `access_denied`; a removed or
|
||||
nonregular replacement reports `artifact_changed`. Source copying is cancellable
|
||||
and never replaces an existing private snapshot.
|
||||
|
||||
```bash
|
||||
rea inspect-native-instruction <binary> <address> --provider ghidra
|
||||
rea resolve-native-call-targets <binary> <call-site> --provider ghidra
|
||||
|
||||
@@ -308,6 +308,18 @@ snapshot is written by an independent real CLI session.
|
||||
They also start a real annotation and snapshot close concurrently: the edit
|
||||
must succeed, the snapshot must be rejected without creating a file, and the
|
||||
edited session must remain usable until explicitly closed.
|
||||
Source-admission probes change a caller-owned fixture after `open_binary` but
|
||||
before the first Ghidra query. They require an actionable `artifact_changed`
|
||||
error preserving both digests and the selected path, unchanged provider
|
||||
availability, failed-copy cleanup, and successful recovery after reopening.
|
||||
After import, deleting that source must preserve the captured database identity.
|
||||
Instruction inspection and containing-function lookup also agree across
|
||||
hexadecimal case, leading zeros, and encoded default address-space spellings.
|
||||
The same source-acquisition workflow exercises missing and directory-replaced
|
||||
inputs, plus real read-permission denial on a non-root host. Root runs report
|
||||
that permission-denial check as unverified. A focused filesystem integration
|
||||
check retains selected-platform routing and exclusive creation; two copy/digest
|
||||
checks duplicated by the real workflow have been removed.
|
||||
Malformed annotation readback, memory completeness, and inventory data remain separate
|
||||
SDK/provider integration cases; success from a real
|
||||
provider cannot establish rejection of a contradictory provider response.
|
||||
|
||||
Reference in New Issue
Block a user