diff --git a/src/domain/managedMemberComparisonItems.ts b/src/domain/managedMemberComparisonItems.ts index fbd6edaa3..5cd9aba76 100644 --- a/src/domain/managedMemberComparisonItems.ts +++ b/src/domain/managedMemberComparisonItems.ts @@ -266,6 +266,20 @@ const fieldOnlyItem = ( }; }; +/** + * Name the identity key an ambiguous group shares. The exact-signature key + * already includes the declared type and name, so names cannot separate it. + */ +const ambiguityLimitation = ( + members: "methods" | "fields", + basis: MethodItem["match"]["basis"], +): string => + basis === "exact-signature" + ? `Multiple managed ${members} share the same declared type, name, and raw signature; REA did not guess a token remap.` + : members === "methods" + ? "Multiple managed methods share the same non-name identity key; REA did not guess a token remap." + : "Multiple managed fields share the same signature; REA did not guess a token remap from names."; + export const buildMethodItems = ( matches: ManagedMethodMatches, context: ComparisonItemContext, @@ -328,9 +342,7 @@ export const buildMethodItems = ( }, dimensions: ["availability"], evidence_links: [context.leftEvidenceId, context.rightEvidenceId], - limitations: [ - "Multiple managed methods share the same non-name identity key; REA did not guess a token remap.", - ], + limitations: [ambiguityLimitation("methods", ambiguous.basis)], }); } const undecoded = undecodedOneSidedNames(matches); @@ -387,9 +399,7 @@ export const buildFieldItems = ( candidate_right_tokens: ambiguous.right.map(({ item }) => item.token), }, evidence_links: [context.leftEvidenceId, context.rightEvidenceId], - limitations: [ - "Multiple managed fields share the same signature; REA did not guess a token remap from names.", - ], + limitations: [ambiguityLimitation("fields", ambiguous.basis)], }); const undecoded = undecodedOneSidedNames(matches); for (const item of matches.leftOnly) diff --git a/tests/boundary/providers/managed/managedMemberComparisonFromMetadata.test.ts b/tests/boundary/providers/managed/managedMemberComparisonFromMetadata.test.ts index ced9314f4..792d5abd6 100644 --- a/tests/boundary/providers/managed/managedMemberComparisonFromMetadata.test.ts +++ b/tests/boundary/providers/managed/managedMemberComparisonFromMetadata.test.ts @@ -374,7 +374,13 @@ describe("managed member comparison of ambiguous undecoded signatures", () => { expect.arrayContaining([ expect.objectContaining({ status: "unknown", - match: expect.objectContaining({ status: "ambiguous" }), + match: expect.objectContaining({ + status: "ambiguous", + basis: "exact-signature", + }), + limitations: [ + "Multiple managed methods share the same declared type, name, and raw signature; REA did not guess a token remap.", + ], }), expect.objectContaining({ status: "unknown",