fix(process): report single empty settlement observation as unverifiable (#2232)
observeSettlement classified a group as alive_at_deadline when the settlement budget expired after one empty observation, though no live member was ever seen. Track observed liveness and return unverifiable when the deadline ends observation with only empty rounds. The two-consecutive-empty rule for quiesced is unchanged, and the cleanup_outcome projection for non-quiesced settlements stays cleaned. Fixes #2170.
This commit is contained in:
@@ -662,6 +662,7 @@ export const observeSettlement = async (
|
||||
}
|
||||
const started = Date.now();
|
||||
let consecutiveEmpty = 0;
|
||||
let sawLive = false;
|
||||
let deadlineReached = false;
|
||||
while (!deadlineReached) {
|
||||
onLiveProgress?.();
|
||||
@@ -685,13 +686,20 @@ export const observeSettlement = async (
|
||||
recordEvent("lifecycle", 1);
|
||||
return { state: "quiesced", elapsed_ms: Date.now() - started };
|
||||
}
|
||||
} else consecutiveEmpty = 0;
|
||||
} else {
|
||||
consecutiveEmpty = 0;
|
||||
sawLive = true;
|
||||
}
|
||||
deadlineReached = Date.now() - started >= settleMs;
|
||||
if (deadlineReached) break;
|
||||
await delay(50, undefined, { signal });
|
||||
}
|
||||
recordEvent("lifecycle", 1);
|
||||
return { state: "alive_at_deadline", elapsed_ms: Date.now() - started };
|
||||
// A lone empty observation proves neither liveness nor quiescence; only an
|
||||
// observed live member justifies alive_at_deadline.
|
||||
return sawLive
|
||||
? { state: "alive_at_deadline", elapsed_ms: Date.now() - started }
|
||||
: { state: "unverifiable", elapsed_ms: Date.now() - started };
|
||||
};
|
||||
|
||||
/** Name why an attempt is unverified; a blank message never reaches the capture schema. */
|
||||
|
||||
Reference in New Issue
Block a user