fix(javascript): retain destructured intrinsic writes

Share one pattern-target walker across lexical definitions, member mutation
tracking and Electron identity writes. Keep overwritten globals unresolved
without treating property keys or shadowed locals as global replacements.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
This commit is contained in:
N0zoM1z0
2026-10-11 14:43:17 +00:00
co-authored by factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com> Kaoru0822
parent ced8778094
commit 824728d7ee
7 changed files with 88 additions and 51 deletions
@@ -2,7 +2,7 @@ import * as t from "@babel/types";
import {
semanticStaticPropertyKey,
semanticMemberWriteTargets,
semanticWriteTargets,
unwrapJavaScriptExpression,
} from "./javascriptAstValues.js";
import { traverseJavaScriptAstSteps } from "./javascriptSemanticTraversal.js";
@@ -135,12 +135,13 @@ export function* collectJavaScriptIdentityWritesSteps(
? node.left
: undefined;
if (target === undefined) return;
if (t.isIdentifier(target)) {
const exported = origin(target, "binding");
if (exported !== undefined) retain(node, exported);
}
for (const member of semanticMemberWriteTargets(target)) {
const { root, members } = electronMemberPath(member);
for (const leaf of semanticWriteTargets(target)) {
if (t.isIdentifier(leaf)) {
const exported = origin(leaf, "binding");
if (exported !== undefined) retain(node, exported);
continue;
}
const { root, members } = electronMemberPath(leaf);
const exported = origin(root, "member");
if (exported !== undefined) retain(node, [...exported, ...members]);
}