refactor(providers): use canonical artifact and managed identities
This commit is contained in:
@@ -33,10 +33,8 @@ import type { JsonValue } from "../domain/jsonValue.js";
|
||||
import { interfaceBuilderLimitsSchema } from "../domain/apple/interfaceBuilderGraph.js";
|
||||
import { err, ok, type Result } from "../domain/result.js";
|
||||
import { ArtifactReaderFailure } from "./ArtifactReader.js";
|
||||
import {
|
||||
ARTIFACT_PROVIDER_IDENTITY as IDENTITY,
|
||||
artifactCapabilities,
|
||||
} from "./ArtifactProviderMetadata.js";
|
||||
import { artifactCapabilities } from "./ArtifactProviderMetadata.js";
|
||||
import { ARTIFACT_GRAPH_PROVIDER } from "../application/InvestigationProviders.js";
|
||||
import { createEvidence } from "../domain/evidence.js";
|
||||
import { createArtifactInspection } from "../domain/artifactInspection.js";
|
||||
|
||||
@@ -56,7 +54,7 @@ export class ArtifactProvider implements AnalysisProvider {
|
||||
}
|
||||
|
||||
identity(): ProviderIdentity {
|
||||
return IDENTITY;
|
||||
return ARTIFACT_GRAPH_PROVIDER;
|
||||
}
|
||||
|
||||
capabilities(): readonly CapabilityDescriptor[] {
|
||||
@@ -81,11 +79,11 @@ class ArtifactClient implements AnalysisClient {
|
||||
options?: ExecutionOptions,
|
||||
) {
|
||||
if (operation === "health")
|
||||
return ok(createAnalysisExecution(null, IDENTITY));
|
||||
return ok(createAnalysisExecution(null, ARTIFACT_GRAPH_PROVIDER));
|
||||
if (!isArtifactOperation(operation))
|
||||
return err(
|
||||
new AnalysisCapabilityUnavailableError(
|
||||
IDENTITY.id,
|
||||
ARTIFACT_GRAPH_PROVIDER.id,
|
||||
operation,
|
||||
"Operation is not implemented by artifact graph provider.",
|
||||
),
|
||||
@@ -113,7 +111,7 @@ class ArtifactClient implements AnalysisClient {
|
||||
...(options?.signal === undefined ? {} : { signal: options.signal }),
|
||||
});
|
||||
return ok(
|
||||
createAnalysisExecution(result, IDENTITY, {
|
||||
createAnalysisExecution(result, ARTIFACT_GRAPH_PROVIDER, {
|
||||
limitations: result.limitations,
|
||||
locations: result.documents.map(({ relative_path: path }) => ({
|
||||
kind: "artifact-path" as const,
|
||||
@@ -166,7 +164,7 @@ class ArtifactClient implements AnalysisClient {
|
||||
`Active archive digest changed: expected ${this.target.sha256}, observed ${result.archive_sha256}`,
|
||||
);
|
||||
return ok(
|
||||
createAnalysisExecution(result, IDENTITY, {
|
||||
createAnalysisExecution(result, ARTIFACT_GRAPH_PROVIDER, {
|
||||
limitations: result.limitations,
|
||||
locations: [{ kind: "artifact-path", path: result.archive_path }],
|
||||
}),
|
||||
@@ -189,7 +187,7 @@ class ArtifactClient implements AnalysisClient {
|
||||
options?.signal,
|
||||
);
|
||||
return ok(
|
||||
createAnalysisExecution(result, IDENTITY, {
|
||||
createAnalysisExecution(result, ARTIFACT_GRAPH_PROVIDER, {
|
||||
rawResult: null,
|
||||
limitations: result.limitations,
|
||||
subject: subjectFor(
|
||||
@@ -206,7 +204,7 @@ class ArtifactClient implements AnalysisClient {
|
||||
const parsed = artifactInventoryInputSchema.parse(parameters);
|
||||
const result = await this.inventory(parsed, options);
|
||||
return ok(
|
||||
createAnalysisExecution(result, IDENTITY, {
|
||||
createAnalysisExecution(result, ARTIFACT_GRAPH_PROVIDER, {
|
||||
rawResult: null,
|
||||
limitations: result.limitations,
|
||||
subject: subjectFor(
|
||||
@@ -262,7 +260,7 @@ class ArtifactClient implements AnalysisClient {
|
||||
...(options?.signal === undefined ? {} : { signal: options.signal }),
|
||||
});
|
||||
return ok(
|
||||
createAnalysisExecution(result, IDENTITY, {
|
||||
createAnalysisExecution(result, ARTIFACT_GRAPH_PROVIDER, {
|
||||
limitations: result.limitations,
|
||||
locations: result.catalogs.map(({ path }) => ({
|
||||
kind: "artifact-path" as const,
|
||||
@@ -296,7 +294,7 @@ class ArtifactClient implements AnalysisClient {
|
||||
...(options?.signal === undefined ? {} : { signal: options.signal }),
|
||||
});
|
||||
return ok(
|
||||
createAnalysisExecution(result, IDENTITY, {
|
||||
createAnalysisExecution(result, ARTIFACT_GRAPH_PROVIDER, {
|
||||
limitations: result.limitations,
|
||||
locations: result.images.map(({ path }) => ({
|
||||
kind: "artifact-path" as const,
|
||||
@@ -329,7 +327,7 @@ class ArtifactClient implements AnalysisClient {
|
||||
kind: "artifact-path" as const,
|
||||
path,
|
||||
}));
|
||||
const inventoryEvidence = createEvidence(subject, IDENTITY, {
|
||||
const inventoryEvidence = createEvidence(subject, ARTIFACT_GRAPH_PROVIDER, {
|
||||
operation: "inventory_artifact",
|
||||
parameters: inventoryParameters,
|
||||
result: inventory,
|
||||
@@ -345,7 +343,7 @@ class ArtifactClient implements AnalysisClient {
|
||||
message: "inventory substep completed",
|
||||
});
|
||||
return ok(
|
||||
createAnalysisExecution(result, IDENTITY, {
|
||||
createAnalysisExecution(result, ARTIFACT_GRAPH_PROVIDER, {
|
||||
rawResult: null,
|
||||
limitations: result.limitations,
|
||||
subject,
|
||||
|
||||
@@ -1,14 +1,7 @@
|
||||
import type {
|
||||
CapabilityDescriptor,
|
||||
ProviderIdentity,
|
||||
} from "../application/AnalysisProvider.js";
|
||||
import type { CapabilityDescriptor } from "../application/AnalysisProvider.js";
|
||||
import { ARTIFACT_GRAPH_PROVIDER } from "../application/InvestigationProviders.js";
|
||||
import { ARTIFACT_ANALYSIS_OPERATIONS } from "../contracts/artifactToolContracts.js";
|
||||
|
||||
/** Identity of artifact inventory and owned extraction observations. */
|
||||
export const ARTIFACT_PROVIDER_IDENTITY: ProviderIdentity = Object.freeze(
|
||||
ARTIFACT_GRAPH_PROVIDER,
|
||||
);
|
||||
/** Declare artifact coverage without constructing readers or acquiring resources. */
|
||||
export const artifactCapabilities = (
|
||||
platform: NodeJS.Platform = process.platform,
|
||||
@@ -16,7 +9,7 @@ export const artifactCapabilities = (
|
||||
Object.freeze(
|
||||
ARTIFACT_ANALYSIS_OPERATIONS.map((operation) => {
|
||||
const common = {
|
||||
provider: ARTIFACT_PROVIDER_IDENTITY,
|
||||
provider: ARTIFACT_GRAPH_PROVIDER,
|
||||
operation,
|
||||
effects: Object.freeze({
|
||||
mutatesArtifact: false,
|
||||
|
||||
Reference in New Issue
Block a user