fix(javascript): resolve module URLs and reject invalid exports targets (#1031)

Resolve module URL paths once and reject invalid root package exports targets before normalization. Preserve actionable graph diagnostics and array selection behavior.

Fixes #1040.

Co-authored-by: Rudy Mizrahi Celekli <47457359+rudycelekli@users.noreply.github.com>
Co-authored-by: Ysopwnable <161784452+N0zoM1z0@users.noreply.github.com>
This commit is contained in:
Rudy Mizrahi Celekli
2026-10-08 14:00:34 +08:00
committed by GitHub
co-authored by Ysopwnable
parent 1d13cef5f4
commit 8d5c88f17c
5 changed files with 591 additions and 25 deletions
@@ -237,18 +237,23 @@ describe("unmatched package export conditions", () => {
},
);
it("does not report valid metadata as malformed", async () => {
const { outcome } = await compareWithNode({ default: 7 }, "import");
expect(outcome.resolution_status).toBe("unavailable");
expect(outcome.limitations[0]).toContain("not valid package JSON");
const { node_error, outcome } = await compareWithNode(
{ default: 7 },
"import",
);
expect(node_error).toBe("ERR_INVALID_PACKAGE_TARGET");
expect(outcome.resolution_status).toBe("rejected");
expect(outcome.limitations[0]).toContain("exports target 7");
expect(outcome.limitations[0]).not.toContain("not valid package JSON");
});
});
describe("package exports fallback refusal reasons", () => {
it.each([
[{ import: [42, 7] }, "ERR_INVALID_PACKAGE_TARGET", "unavailable"],
[{ import: [42, 7] }, "ERR_INVALID_PACKAGE_TARGET", "rejected"],
[{ import: [null, null] }, "ERR_PACKAGE_PATH_NOT_EXPORTED", "external"],
[{ import: [42, null] }, "ERR_PACKAGE_PATH_NOT_EXPORTED", "external"],
[{ import: [null, 42] }, "ERR_INVALID_PACKAGE_TARGET", "unavailable"],
[{ import: [null, 42] }, "ERR_INVALID_PACKAGE_TARGET", "rejected"],
[
{ import: { node: null }, default: "./default.cjs" },
"ERR_PACKAGE_PATH_NOT_EXPORTED",
@@ -265,6 +270,10 @@ describe("package exports fallback refusal reasons", () => {
expect(node_error).toBe(code);
expect(outcome.resolved_path).toBeNull();
expect(outcome.resolution_status).toBe(status);
if (code === "ERR_INVALID_PACKAGE_TARGET") {
expect(outcome.limitations[0]).toContain("exports target");
expect(outcome.limitations[0]).not.toContain("not valid package JSON");
}
},
);
});