fix(cli): retain browser and Inspector input correction details (#2230)

Reuse the shared safe issue projection for all six CLI validation boundaries
and cover malformed inputs, credential safety, and parser diagnostics.

Fixes morluto/rea#2180

Developed with assistance from OpenAI Codex.
This commit is contained in:
No BS AI
2026-10-13 02:29:07 +08:00
committed by GitHub
parent fd985dbc5b
commit 916ac97bf9
3 changed files with 247 additions and 23 deletions
+39 -13
View File
@@ -14,7 +14,7 @@ import {
} from "../domain/browserObservation.js";
import { analyzeWebBundleInputSchema } from "../domain/webBundleAnalysis.js";
import { observeWebSessionInputSchema } from "../domain/browserSession.js";
import { AnalysisInputError } from "../domain/analysisErrorCore.js";
import { analysisInputErrorFromIssues } from "../domain/inputIssueProjection.js";
import type { Logger } from "pino";
import { CLI_COMMANDS } from "../cliCommandNames.js";
import {
@@ -48,13 +48,18 @@ const registerTargetList = (
run: ({ args, options }) =>
logCliCommand(logger, "list-browser-targets", async () => {
const context = browserContext();
const parsed = listBrowserTargetsInputSchema.safeParse({
const input = {
cdp_endpoint: args.endpoint,
allowed_origins: options.allowedOrigins,
});
};
const parsed = listBrowserTargetsInputSchema.safeParse(input);
if (!parsed.success)
return browserCliError(
new AnalysisInputError("list_browser_targets"),
analysisInputErrorFromIssues(
"list_browser_targets",
parsed.error.issues,
input,
),
);
const result = await listBrowserTargets(context.provider, parsed.data);
return result.ok ? result.value : browserCliError(result.error);
@@ -77,7 +82,7 @@ const registerPageInspection = (
run: ({ args, options }) =>
logCliCommand(logger, "inspect-web-page", async () => {
const context = browserContext();
const parsed = inspectWebPageInputSchema.safeParse({
const input = {
cdp_endpoint: args.endpoint,
allowed_origins: options.allowedOrigins,
target_id: args.targetId,
@@ -89,9 +94,16 @@ const registerPageInspection = (
include_script_sources: options.includeScriptSources,
include_storage_keys: options.includeStorageKeys,
include_storage_fingerprints: options.includeStorageFingerprints,
});
};
const parsed = inspectWebPageInputSchema.safeParse(input);
if (!parsed.success)
return browserCliError(new AnalysisInputError("inspect_web_page"));
return browserCliError(
analysisInputErrorFromIssues(
"inspect_web_page",
parsed.error.issues,
input,
),
);
const result = await inspectWebPage(context.provider, parsed.data);
return result.ok ? result.value : browserCliError(result.error);
}),
@@ -120,16 +132,23 @@ const registerBundleAnalysis = (
run: ({ args, options }) =>
logCliCommand(logger, "analyze-web-bundle", async () => {
const context = browserContext();
const parsed = analyzeWebBundleInputSchema.safeParse({
const input = {
cdp_endpoint: args.endpoint,
allowed_origins: options.allowedOrigins,
target_id: args.targetId,
observation_ms: options.observationMs,
include_script_sources: true,
fetch_source_maps: options.fetchSourceMaps,
});
};
const parsed = analyzeWebBundleInputSchema.safeParse(input);
if (!parsed.success)
return browserCliError(new AnalysisInputError("analyze_web_bundle"));
return browserCliError(
analysisInputErrorFromIssues(
"analyze_web_bundle",
parsed.error.issues,
input,
),
);
const result = await analyzeWebBundle(context.provider, parsed.data);
return result.ok ? result.value : browserCliError(result.error);
}),
@@ -153,14 +172,21 @@ const registerObservationSession = (
run: ({ args, options }) =>
logCliCommand(logger, "observe-web-session", async () => {
const context = browserContext();
const parsed = observeWebSessionInputSchema.safeParse({
const input = {
cdp_endpoint: args.endpoint,
allowed_origins: options.allowedOrigins,
target_id: args.targetId,
observation_ms: options.observationMs,
});
};
const parsed = observeWebSessionInputSchema.safeParse(input);
if (!parsed.success)
return browserCliError(new AnalysisInputError("observe_web_session"));
return browserCliError(
analysisInputErrorFromIssues(
"observe_web_session",
parsed.error.issues,
input,
),
);
const result = await observeWebSession(context.provider, parsed.data);
return result.ok ? result.value : browserCliError(result.error);
}),