fix(ghidra): preserve Unicode boundaries without breaking sessions
Validate native annotation text before mutation and escape surrogate code units in Java bridge JSON replies. Reject unsupported text with field and index diagnostics while preserving supported Unicode and line endings. Probe real CLI/MCP annotation, transport, mapping, rollback and cleanup behavior; replace seven redundant unit tests with E2E and SDK boundary coverage.
This commit is contained in:
@@ -257,7 +257,10 @@ protected runtime DACLs, and handle-based path admission. See [Windows Ghidra P0
|
||||
[issue #527](https://github.com/morluto/rea/issues/527).
|
||||
On Linux and macOS, `annotate_native_function` atomically edits a function name
|
||||
and entry comments in the ephemeral database, returning refreshed analysis
|
||||
without changing executable bytes. Windows P0 remains read-only. Ghidra has no
|
||||
without changing executable bytes. Annotation text must contain no NUL or
|
||||
unpaired Unicode surrogate; a rejection identifies the field and UTF-16 index
|
||||
and leaves every annotation unchanged. CRLF, supplementary Unicode characters,
|
||||
and combining characters are preserved. Windows P0 remains read-only. Ghidra has no
|
||||
GUI authority, and REA never falls back automatically to Hopper.
|
||||
|
||||
- `npm run verify:ghidra`: host-native debug/stripped targets, native type layout,
|
||||
|
||||
+6
-2
@@ -249,8 +249,12 @@ direct versus targetless calls, byte-read completeness, invalid input diagnostic
|
||||
CLI/MCP parity, atomic annotation rollback, refreshed inventories, unchanged
|
||||
executable bytes, and discarded edits after reopen. A deliberately long temporary
|
||||
path exercises private Unix socket allocation and cleanup, including cancellation
|
||||
after a real headless process launches. Malformed annotation
|
||||
readback remains a separate SDK/provider integration case; success from a real
|
||||
after a real headless process launches. Native annotation probes reject NUL and
|
||||
unpaired Unicode surrogates without partial edits or a broken bridge, preserve
|
||||
supported Unicode and control text, and check lossless malformed-text diagnostics.
|
||||
Memory-to-file mapping is checked against original artifact bytes. Malformed
|
||||
annotation readback, memory completeness, and inventory data remain separate
|
||||
SDK/provider integration cases; success from a real
|
||||
provider cannot establish rejection of a contradictory provider response.
|
||||
|
||||
The Linux switch lane checks dense, sparse-with-holes, shared-body, nonzero,
|
||||
|
||||
Reference in New Issue
Block a user