fix(cli): preserve output and comparison input validation (#981)
This commit is contained in:
@@ -57,7 +57,9 @@ describe("CLI output argument and sanitization boundary", () => {
|
||||
validateCliOutputArguments(["providers", "--token-count", "--json"]),
|
||||
).toEqual({ ok: true });
|
||||
});
|
||||
});
|
||||
|
||||
describe("CLI output valued-flag parsing", () => {
|
||||
workspaceCliTest(
|
||||
"preserves complete JSON errors when native builtin flags follow unusual arguments",
|
||||
async ({ cli }) => {
|
||||
@@ -92,6 +94,70 @@ describe("CLI output argument and sanitization boundary", () => {
|
||||
CLI_INTEGRATION_TIMEOUT_MS,
|
||||
);
|
||||
|
||||
workspaceCliTest(
|
||||
"does not treat empty or equals-style output values as active builtins",
|
||||
async ({ cli }) => {
|
||||
for (const arguments_ of [
|
||||
["capabilities", "--json", "--format", ""],
|
||||
["capabilities", "--json", "--filter-output", ""],
|
||||
["capabilities", "--json", "--token-limit", ""],
|
||||
["capabilities", "--json", "--token-limit=5"],
|
||||
]) {
|
||||
const result = await cli.run({ arguments: arguments_ });
|
||||
expect(result.exitCode).toBe(1);
|
||||
expect(result.json).toBeDefined();
|
||||
expect(result.stdout).not.toContain("[truncated:");
|
||||
expect(JSON.stringify(result.json)).not.toContain(
|
||||
"UNSUPPORTED_OUTPUT_COMBINATION",
|
||||
);
|
||||
}
|
||||
const validTokenWindow = await cli.run({
|
||||
arguments: ["capabilities", "--json", "--token-limit", "5"],
|
||||
});
|
||||
expect(validTokenWindow.exitCode).toBe(1);
|
||||
expect(validTokenWindow.json).toMatchObject({
|
||||
ok: false,
|
||||
error: { code: "UNSUPPORTED_OUTPUT_COMBINATION" },
|
||||
});
|
||||
const emptyFormatWithTokenWindow = await cli.run({
|
||||
arguments: [
|
||||
"capabilities",
|
||||
"--json",
|
||||
"--format",
|
||||
"",
|
||||
"--token-limit",
|
||||
"5",
|
||||
],
|
||||
});
|
||||
expect(emptyFormatWithTokenWindow.exitCode).toBe(1);
|
||||
expect(emptyFormatWithTokenWindow.stdout).not.toContain("[truncated:");
|
||||
expect(emptyFormatWithTokenWindow.json).toMatchObject({
|
||||
ok: false,
|
||||
error: { code: "UNSUPPORTED_OUTPUT_COMBINATION" },
|
||||
});
|
||||
|
||||
for (const arguments_ of [
|
||||
["capabilities", "--json", "--token-limit", "not-a-number"],
|
||||
[
|
||||
"capabilities",
|
||||
"--format",
|
||||
"unsupported-format",
|
||||
"--json",
|
||||
"--token-limit",
|
||||
"5",
|
||||
],
|
||||
]) {
|
||||
const result = await cli.run({ arguments: arguments_ });
|
||||
expect(result.exitCode).toBe(1);
|
||||
expect(result.stdout).not.toContain("UNSUPPORTED_OUTPUT_COMBINATION");
|
||||
expect(result.stdout).not.toContain("[truncated:");
|
||||
}
|
||||
},
|
||||
CLI_INTEGRATION_TIMEOUT_MS,
|
||||
);
|
||||
});
|
||||
|
||||
describe("CLI output argument and sanitization boundary", () => {
|
||||
it("preserves normal output and sanitizes text and JSON validation errors", () => {
|
||||
expect(sanitizeCliOutput("result: ok\n")).toBe("result: ok\n");
|
||||
expect(sanitizeCliOutput("result: VALIDATION_ERROR\n")).toBe(
|
||||
|
||||
Reference in New Issue
Block a user