From e6ba9c3af3053485f154825eea6a156127328be9 Mon Sep 17 00:00:00 2001 From: ysopwnable <161784452+N0zoM1z0@users.noreply.github.com> Date: Wed, 7 Oct 2026 19:08:45 +0800 Subject: [PATCH] fix(javascript): retain recovered call argument positions (#929) --- ...emanticAnalysis.recoveredArguments.test.ts | 40 +++++++++++++++++++ .../javascript/javascriptSemanticCalls.ts | 3 ++ 2 files changed, 43 insertions(+) create mode 100644 src/domain/javascript/javascriptSemanticAnalysis.recoveredArguments.test.ts diff --git a/src/domain/javascript/javascriptSemanticAnalysis.recoveredArguments.test.ts b/src/domain/javascript/javascriptSemanticAnalysis.recoveredArguments.test.ts new file mode 100644 index 000000000..98e5516f1 --- /dev/null +++ b/src/domain/javascript/javascriptSemanticAnalysis.recoveredArguments.test.ts @@ -0,0 +1,40 @@ +import { describe, expect, it } from "vitest"; + +import { analyzeJavaScriptSemantics } from "./javascriptSemanticAnalysis.js"; + +describe("JavaScript semantic analysis: recovered arguments", () => { + it.each([ + { source: "0(,)", indexes: [] }, + { source: 'call(, "kept", , 42)', indexes: [1, 3] }, + { source: 'call?.(, "kept")', indexes: [1] }, + { source: 'new Thing(, "kept")', indexes: [1] }, + ])( + "retains argument positions in recovered syntax: $source", + ({ source, indexes }) => { + const ir = analyzeJavaScriptSemantics(source); + + expect(ir.coverage.status).toBe("partial"); + expect(ir.callSites).toHaveLength(1); + expect(ir.callSites[0]?.arguments.map(({ index }) => index)).toEqual( + indexes, + ); + expect(ir.limitations.join(" ")).toMatch(/parser recovered/iu); + }, + ); + + it("keeps recovered argument flows bound to their original parameter", () => { + const ir = analyzeJavaScriptSemantics( + "function select(first, second) { return second; } const value = 42; select(, value);", + ); + const second = ir.bindings.find(({ name }) => name === "second"); + + expect(ir.coverage.status).toBe("partial"); + expect(second).toBeDefined(); + expect(ir.argumentFlows).toEqual([ + expect.objectContaining({ + argumentIndex: 1, + parameterBindingId: second?.bindingId, + }), + ]); + }); +}); diff --git a/src/domain/javascript/javascriptSemanticCalls.ts b/src/domain/javascript/javascriptSemanticCalls.ts index 0a626b49c..e3e866286 100644 --- a/src/domain/javascript/javascriptSemanticCalls.ts +++ b/src/domain/javascript/javascriptSemanticCalls.ts @@ -210,10 +210,13 @@ const retainedArguments = ( | t.SpreadElement | t.JSXNamespacedName | t.ArgumentPlaceholder + | null )[], ): JavaScriptSemanticCallSite["arguments"] => { const retained: JavaScriptSemanticCallSite["arguments"][number][] = []; for (const [index, node] of nodes.entries()) { + // Babel recovery can leave null slots; retain the other argument positions. + if (node === null) continue; retained.push({ index, location: range(node),