refactor(mcp): simplify tool inputs and inline results

This commit is contained in:
morluto
2026-09-29 11:22:00 +08:00
parent bd0e341572
commit f55c2b9267
70 changed files with 468 additions and 741 deletions
+2 -2
View File
@@ -124,8 +124,8 @@ const browserParameters = (
};
if (isScreenshotComparison(input))
return {
before_artifact_uri: input.before.uri,
after_artifact_uri: input.after.uri,
before_artifact_sha256: input.before.sha256,
after_artifact_sha256: input.after.sha256,
channel_threshold: input.channel_threshold,
maximum_pixels: input.maximum_pixels,
};
+1 -1
View File
@@ -30,7 +30,7 @@ const browserScenarioParameters = (
}),
),
capture: scenario.capture,
limits: scenario.limits,
limits: { ...scenario.limits },
});
/** Create Evidence without retaining resolved scenario secret values. */
-1
View File
@@ -72,7 +72,6 @@ type AvailabilityContext = {
};
const ENHANCED_REQUIREMENTS: Readonly<Record<string, readonly string[]>> = {
swift_classes: ["list_procedures"],
get_objc_classes: ["list_names"],
get_objc_protocols: ["list_names"],
batch_decompile: ["procedure_pseudo_code"],
+13 -21
View File
@@ -26,7 +26,6 @@ import {
categorizeSwiftTypes,
discoverObjcClasses,
discoverObjcProtocols,
discoverSwiftClasses,
} from "../domain/symbolAnalysis.js";
import { jsonValueSchema, type JsonValue } from "../domain/jsonValue.js";
@@ -63,12 +62,6 @@ export class EnhancedTools {
if (name === "analyze_function" || name === "inspect_native_api")
return this.#executeFunctionAnalysis(name, input, signal);
switch (name) {
case "swift_classes": {
const parsed = enhancedInputSchemas.swift_classes.safeParse(input);
return parsed.success
? this.executeValidated({ name, input: parsed.data }, signal)
: invalidEnhancedInput(name, parsed.error);
}
case "get_objc_classes": {
const parsed = enhancedInputSchemas.get_objc_classes.safeParse(input);
return parsed.success
@@ -89,8 +82,13 @@ export class EnhancedTools {
? this.executeValidated({ name, input: parsed.data }, signal)
: invalidEnhancedInput(name, parsed.error);
}
case "analyze_swift_types":
return this.executeValidated({ name, input: {} }, signal);
case "analyze_swift_types": {
const parsed =
enhancedInputSchemas.analyze_swift_types.safeParse(input);
return parsed.success
? this.executeValidated({ name, input: parsed.data }, signal)
: invalidEnhancedInput(name, parsed.error);
}
case "find_xrefs_to_name": {
const parsed = enhancedInputSchemas.find_xrefs_to_name.safeParse(input);
return parsed.success
@@ -112,8 +110,6 @@ export class EnhancedTools {
signal?: AbortSignal,
): EnhancedResult {
switch (call.name) {
case "swift_classes":
return this.#swiftClasses(call.input.pattern, signal);
case "get_objc_classes":
return this.#objcClasses(call.input.pattern, signal);
case "get_objc_protocols":
@@ -123,7 +119,7 @@ export class EnhancedTools {
case "get_call_graph":
return this.#callGraph(call.input, signal);
case "analyze_swift_types":
return this.#analyzeSwiftTypes(signal);
return this.#analyzeSwiftTypes(call.input, signal);
case "find_xrefs_to_name":
return this.#findXrefs(call.input.name, signal);
case "binary_overview":
@@ -216,13 +212,6 @@ export class EnhancedTools {
return ok(jsonValueSchema.parse(projectNativeApiInspection(dossier)));
}
async #swiftClasses(pattern: string, signal?: AbortSignal): EnhancedResult {
const procedures = await this.#allAddressed("list_procedures", signal);
return procedures.ok
? ok(discoverSwiftClasses(procedures.value, pattern))
: procedures;
}
async #objcClasses(pattern: string, signal?: AbortSignal): EnhancedResult {
const names = await this.#allAddressed("list_names", signal);
return names.ok ? ok(discoverObjcClasses(names.value, pattern)) : names;
@@ -333,10 +322,13 @@ export class EnhancedTools {
return ok(graph);
}
async #analyzeSwiftTypes(signal?: AbortSignal): EnhancedResult {
async #analyzeSwiftTypes(
input: z.output<typeof enhancedInputSchemas.analyze_swift_types>,
signal?: AbortSignal,
): EnhancedResult {
const procedures = await this.#allAddressed("list_procedures", signal);
return procedures.ok
? ok(categorizeSwiftTypes(procedures.value))
? ok(categorizeSwiftTypes(procedures.value, input))
: procedures;
}