refactor(javascript): reuse validated source-map decoding
Pass typed map objects into the codec and reuse validated TraceMap instances for regular and indexed lookups. Remove whole-map serialization, duplicate leaf decoding, an array-copy wrapper, and the unused offset-validation mode in artifact declaration collection. Validation: source-map and browser consumer suites (126 tests), declaration tests, and artifact reconstruction boundaries pass. Section overlap checks and raw source declarations remain intact.
This commit is contained in:
@@ -1,11 +1,4 @@
|
||||
/**
|
||||
* Structural walk over indexed source-map envelopes. Both the browser
|
||||
* source-map fetcher and the artifact source-map reader accept version-3
|
||||
* maps with recursively indexed `sections`; this module owns that walk so
|
||||
* the two validators cannot drift. Leaf content checks (mappings, sources,
|
||||
* names, contents) stay with the callers, which enforce different
|
||||
* strictness.
|
||||
*/
|
||||
/** Artifact source declarations do not require generated-position decoding. */
|
||||
type SourceMapRecord = Readonly<Record<string, unknown>>;
|
||||
|
||||
/**
|
||||
@@ -25,17 +18,9 @@ const isRecord = (value: unknown): value is SourceMapRecord =>
|
||||
typeof value === "object" && value !== null && !Array.isArray(value);
|
||||
|
||||
/** Whether a parsed value has the version-3 map shape. */
|
||||
export const isVersion3Map = (value: unknown): value is SourceMapRecord =>
|
||||
const isVersion3Map = (value: unknown): value is SourceMapRecord =>
|
||||
isRecord(value) && value.version === 3;
|
||||
|
||||
const isValidOffset = (value: unknown): boolean =>
|
||||
typeof value === "number" && Number.isSafeInteger(value) && value >= 0;
|
||||
|
||||
export interface FlattenSourceMapOptions {
|
||||
/** Require each section offset to carry safe-integer line/column. */
|
||||
readonly validateOffsets?: boolean;
|
||||
}
|
||||
|
||||
/**
|
||||
* Collect leaf maps from an indexed source-map envelope, or undefined when
|
||||
* the envelope is not a version-3 map. A map carrying neither `mappings`
|
||||
@@ -44,7 +29,6 @@ export interface FlattenSourceMapOptions {
|
||||
*/
|
||||
export const flattenSourceMapLeaves = (
|
||||
root: unknown,
|
||||
options?: FlattenSourceMapOptions,
|
||||
): readonly SourceMapRecord[] | undefined => {
|
||||
if (!isVersion3Map(root)) return undefined;
|
||||
const leaves: SourceMapRecord[] = [];
|
||||
@@ -55,14 +39,6 @@ export const flattenSourceMapLeaves = (
|
||||
if (Array.isArray(map.sections)) {
|
||||
for (const section of map.sections) {
|
||||
if (!isRecord(section) || !isRecord(section.map)) return undefined;
|
||||
if (options?.validateOffsets === true) {
|
||||
if (!isRecord(section.offset)) return undefined;
|
||||
if (
|
||||
!isValidOffset(section.offset.line) ||
|
||||
!isValidOffset(section.offset.column)
|
||||
)
|
||||
return undefined;
|
||||
}
|
||||
pending.push(section.map);
|
||||
}
|
||||
} else leaves.push(map);
|
||||
|
||||
Reference in New Issue
Block a user