fix(pcap): order evidence ties by code point instead of host locale (#2509)
The pcap summary sorted equal-count endpoints and protocol stacks with String#localeCompare, and Flutter build inspection sorted APK ABI directory names the same way. localeCompare follows the host's ICU locale, so the same capture produced differently ordered Evidence on different hosts: under da_DK "aarp" sorts after "zz", under lt_LT "syslog" sorts before "ssdp", and every locale puts "fe80::1" before "fe80:1::1". Use the repository's compareUnicodeCodePoints, as the other Evidence producers already do. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
d73ed6fce2
commit
f6556ad2bc
@@ -23,6 +23,7 @@ import {
|
||||
AnalysisUnsupportedTargetError,
|
||||
} from "../domain/analysisErrorCore.js";
|
||||
import { AnalysisProtocolError } from "../domain/analysisErrorCore.js";
|
||||
import { compareUnicodeCodePoints } from "../domain/unicodeCodePointOrder.js";
|
||||
import { AnalysisError } from "../domain/analysisErrorBase.js";
|
||||
import { err, ok, type Result } from "../domain/result.js";
|
||||
import {
|
||||
@@ -759,7 +760,7 @@ export class FlutterBuildProvider {
|
||||
toolchain_capped: value.libflutter.toolchainCapped,
|
||||
},
|
||||
}))
|
||||
.sort((left, right) => left.abi.localeCompare(right.abi));
|
||||
.sort((left, right) => compareUnicodeCodePoints(left.abi, right.abi));
|
||||
const flutterDetected = abis.some((entry) => entry.libapp.present);
|
||||
const partial =
|
||||
abis.some(
|
||||
@@ -871,7 +872,7 @@ export class FlutterBuildProvider {
|
||||
(left, right) =>
|
||||
(preference.indexOf(left.abi) + 1 || preference.length + 1) -
|
||||
(preference.indexOf(right.abi) + 1 || preference.length + 1) ||
|
||||
left.abi.localeCompare(right.abi),
|
||||
compareUnicodeCodePoints(left.abi, right.abi),
|
||||
)[0]!
|
||||
: candidates.find((candidate) => candidate.abi === abi);
|
||||
if (selected === undefined)
|
||||
|
||||
Reference in New Issue
Block a user