* feat(process): add owned debugger shutdown lifecycle * feat(reverse): add local inspection commands * feat(gdb): add persistent debugger integration * feat(cutter): add Cutter bridge integration * test(reverse): enforce complete integration coverage * fix(process): preserve debugger shutdown ownership * fix(reverse): retain evidence across interrupted commands * fix(gdb): honor captured provider environment * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * fix(server): snapshot provider environment at creation * fix(reverse): close review gaps with complete coverage * fix(reverse): address inspection review findings * fix(gdb): bound sessions and retain cleanup ownership * fix(ci): require reverse-tools quality lane * fix(process): unref inherited debugger output pipes * fix(reverse): address remaining PR 1960 findings * fix(gdb): address remaining PR 1961 findings * fix(reverse): account for unrestricted provider execution * fix(process): retain debugger ownership until safe shutdown * fix(process): preserve replacement debugger sessions * fix(reverse): preserve admission and output provenance * fix(process): retain exited debugger until output settles * fix(mcp): bound provider admission and debugger cleanup * fix(reverse): preserve failure provenance and classify E2BIG * fix(gdb): preserve startup cleanup and detach safety * fix(process): retain debugger ownership after detach failure * fix(reverse): preserve mutation and failure provenance * fix(gdb): address debugger review findings * fix(reverse): rebind sessions after external mutation * fix(process): cap debugger output after exit * fix(gdb): protect one-shot detach verification * feat(debugger): add reverse tool coverage gate * test(debugger): cover integrated failure paths * fix(gdb): bound and preserve session observations * fix(gdb): address review regressions * style: format merged integration files * fix(reverse): preserve session and output evidence * refactor(gdb): share repeated test and partial result setup * fix(gdb): invalidate TTY proof for Python aliases * fix(reverse): retain failure output byte counts * test(process): synchronize late debugger output * fix(gdb): invalidate TTY proof for wrapped commands * fix(gdb): recognize wit command abbreviation * test(reverse): wait for cancelled descendant readiness * test(reverse): bound descendant cancellation cleanup * style(reverse): format integration tests and adapters * style: format reverse engineering integration files * test(reverse): remove duplicate environment harness * test(gdb): share session startup assertions * fix(gdb): invalidate output proof for command abbreviations * test(reverse): share composition edge case scenarios * fix(ci): recognize verification and mutation tool entries * test(rizin): cover successful fake inferior detach * test(cli): align full output failure envelope * test(cli): isolate reverse command lifecycle service * test(process): share debugger output fixture setup * fix(binary): preserve high-bit Windows signature bytes * style(binary): format Windows signature parser * test(mcp): preserve call coverage in unchanged comparison * fix(ci): include reverse tools Vitest configs in lint cache * fix(mcp): preserve target content on delivery errors * ci: align duplication ceiling with expanded suite * test(reverse): allow signal admission mutants * fix(reverse): bound retained cleanup failures to process owners * fix(test): replace drifting mutation ranges with owned selectors * fix(reverse): admit persistent commands and retain cleanup ownership * fix(cutter): recover timed-out commands from exact receipts * fix(cutter): reject unsupported bridge request kinds * fix(ci): repair client format and shared verification fixtures * fix(native): preserve debugger cleanup ownership and bridge authentication * test(native): retain diagnostics without perfect coverage requirements * chore(licenses): refresh locked dependency inventory and notices * fix(test): exclude transient command locks from mutation sandboxes * fix(gdb): admit only platforms with safe detach verification * fix(cutter): retain bounded completion receipts until acknowledgement * fix(cutter): acknowledge commands rejected before UI dispatch * test(reverse): fail cancellation checks before fixture teardown * test(gdb): clean up the retained broken-stdin fixture owner * docs(test): clarify focused provider verification scope * fix(rizin): retain close cleanup failures * fix(gdb): wait for inferior stop and bound MI buffering * fix(cutter): retain failed receipt acknowledgements * fix(rizin): return retained session identity on rebind failure * fix(gdb): preserve startup cancellation and lossy status * fix(rizin): retain launch provenance and assemble frames once * fix(cutter): recover receipts across callers and bound discovery * docs: describe debugger evidence and bridge recovery * fix(process): keep cleanup incomplete while writers remain Stopping a debugger no longer reports success when inherited output streams stay open, so BinarySession cannot reopen a binary a child is still changing. Concurrent Cutter cleanup retries share one receipt acknowledgement instead of treating a consumed receipt as failure. * fix(debuggers): recover cleanup with captured process identities * fix(analysis): retire sessions after unrestricted commands * fix(cli): preserve completed evidence after cleanup recovery * fix(cutter): bound frame collection and coalesce cleanup * fix(windows): resolve selected provider paths absolutely * fix(gdb): report decoding loss in failed startup evidence * fix(rizin): scope decoding loss to collected command frames * test(mcp): cover snapshot retirement in reverse tools CI --------- Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com> Co-authored-by: REA Maintainers <noreply@github.com> Co-authored-by: OpenAI Codex <codex@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
252 lines
8.0 KiB
TypeScript
252 lines
8.0 KiB
TypeScript
import { expect, it } from "vitest";
|
|
|
|
import { NativeMacOSProvider } from "../../../../src/native/NativeMacOSProvider.js";
|
|
import { parseOtoolLoadCommands } from "../../../../src/native/parsers/otool.js";
|
|
import {
|
|
NativeFixtureRunner,
|
|
nativeFixture,
|
|
nativeMachoTarget,
|
|
withOtoolMachHeader,
|
|
} from "../../../fixtures/nativeCommands.js";
|
|
|
|
it("retains the delayed dependency in the complete real framed otool output", async () => {
|
|
const output = await nativeFixture("otool-dylib-use.txt");
|
|
const runner = new NativeFixtureRunner({ "otool:-h": output });
|
|
const client = new NativeMacOSProvider({}, runner, "darwin").createClient(
|
|
nativeMachoTarget("/owned/fixture"),
|
|
);
|
|
const result = await client.execute("inspect_macho", {});
|
|
if (!result.ok) throw result.error;
|
|
expect(result.value.result).toMatchObject({
|
|
load_commands: {
|
|
items: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
index: 16,
|
|
kind: "LC_LOAD_DYLIB",
|
|
fields: expect.objectContaining({ options: "delay-init" }),
|
|
}),
|
|
]),
|
|
},
|
|
dependencies: {
|
|
items: expect.arrayContaining([
|
|
expect.objectContaining({
|
|
path: "@rpath/libdelay.dylib",
|
|
current_version: "0.0.0",
|
|
compatibility_version: "1.0.0",
|
|
}),
|
|
]),
|
|
},
|
|
});
|
|
expect(parseOtoolLoadCommands(output).commands).toHaveLength(23);
|
|
});
|
|
|
|
it("rejects a repeated options field even when the duplicate has no value", async () => {
|
|
const output = (await nativeFixture("otool-dylib-use.txt")).replace(
|
|
" options delay-init",
|
|
" options delay-init\n options",
|
|
);
|
|
expect(() => parseOtoolLoadCommands(output)).toThrow(/otool/u);
|
|
});
|
|
|
|
it.each([
|
|
"vmaddr",
|
|
"vmsize",
|
|
"uuid",
|
|
"entryoff",
|
|
"addr",
|
|
"current version",
|
|
"time stamp",
|
|
])(
|
|
"rejects a required %s label with no value and retains its producer output",
|
|
async (field) => {
|
|
const original = await nativeFixture("otool-load.txt");
|
|
const output = original.replace(
|
|
new RegExp(`^([ \\t]*${field})[ \\t]+\\S[^\\n]*$`, "mu"),
|
|
"$1",
|
|
);
|
|
if (output === original) throw new Error(`Fixture has no ${field} value`);
|
|
const runner = new NativeFixtureRunner({ "otool:-h": output });
|
|
const client = new NativeMacOSProvider({}, runner, "darwin").createClient(
|
|
nativeMachoTarget("/owned/fixture"),
|
|
);
|
|
const result = await client.execute("inspect_macho", {});
|
|
if (result.ok) throw new Error(`Expected missing ${field} value rejection`);
|
|
expect(result.error).toMatchObject({
|
|
_tag: "AnalysisOutputError",
|
|
capturedOutput: { stdout: output, stderr: "", truncated: false },
|
|
});
|
|
expect(result.error.cause).toMatchObject({
|
|
message: expect.stringContaining(field),
|
|
});
|
|
},
|
|
);
|
|
|
|
it("collects the actual Mach header alongside the native load commands", async () => {
|
|
// The provider always invokes `otool -h -l`, which the runner resolves
|
|
// via the "otool:-h" key; no bare `otool` override is needed.
|
|
const runner = new NativeFixtureRunner({
|
|
"otool:-h": await nativeFixture(
|
|
"native-macho-header/otool-header-load.txt",
|
|
),
|
|
});
|
|
const client = new NativeMacOSProvider({}, runner, "darwin").createClient(
|
|
nativeMachoTarget("/owned/fixture"),
|
|
);
|
|
const result = await client.execute("inspect_macho", {});
|
|
if (!result.ok) throw result.error;
|
|
expect(result.value.result).toMatchObject({
|
|
file_type: "2",
|
|
flags: ["0x00200085"],
|
|
segments: {
|
|
items: expect.arrayContaining([
|
|
expect.objectContaining({ name: "__TEXT" }),
|
|
]),
|
|
},
|
|
});
|
|
});
|
|
|
|
it("rejects line breaks in a dylib name that manufacture a command and retains otool output", async () => {
|
|
const output = [
|
|
"/owned/fixture:",
|
|
"Mach header",
|
|
" magic cputype cpusubtype caps filetype ncmds sizeofcmds flags",
|
|
" 0xfeedfacf 16777228 0 0x00 2 1 120 0x00000000",
|
|
"Load command 0",
|
|
" cmd LC_LOAD_DYLIB",
|
|
" cmdsize 120",
|
|
" name @rpath/a",
|
|
"Load command 77",
|
|
" cmd LC_REEXPORT_DYLIB",
|
|
" name /evil.dylib (offset 24)",
|
|
" time stamp 2 Thu Jan 1 00:00:02 1970",
|
|
" current version 1.0.0",
|
|
"compatibility version 1.0.0",
|
|
"",
|
|
].join("\n");
|
|
const runner = new NativeFixtureRunner({ "otool:-h": output });
|
|
const client = new NativeMacOSProvider({}, runner, "darwin").createClient(
|
|
nativeMachoTarget("/owned/fixture"),
|
|
);
|
|
const result = await client.execute("inspect_macho", {});
|
|
if (result.ok) throw new Error("expected malformed otool framing to fail");
|
|
expect(result.error).toMatchObject({
|
|
_tag: "AnalysisOutputError",
|
|
capturedOutput: { stdout: output, stderr: "", truncated: false },
|
|
});
|
|
});
|
|
|
|
it("does not reinterpret segment and section flags as Mach header flags", async () => {
|
|
const load = parseOtoolLoadCommands(
|
|
await nativeFixture("native-macho-header/otool-header-load.txt"),
|
|
);
|
|
expect(load.flags).toEqual(["0x00200085"]);
|
|
expect(load.commands.some((command) => command.fields.flags === 0)).toBe(
|
|
true,
|
|
);
|
|
});
|
|
|
|
it("keeps multi-word field names such as time stamp intact", async () => {
|
|
const load = parseOtoolLoadCommands(await nativeFixture("otool-load.txt"));
|
|
const stamped = load.commands.filter(
|
|
(command) => "time stamp" in command.fields,
|
|
);
|
|
expect(stamped.length).toBeGreaterThan(0);
|
|
expect(load.commands.some((command) => "time" in command.fields)).toBe(false);
|
|
expect(stamped[0]?.fields["time stamp"]).toMatch(/^2 Thu Jan/);
|
|
});
|
|
|
|
it("decodes Mach header fields by their column names", () => {
|
|
const reordered = parseOtoolLoadCommands(
|
|
[
|
|
"Mach header",
|
|
" flags filetype magic cputype ncmds sizeofcmds",
|
|
" NOUNDEFS 2 0xfeedfacf 16777228 0 0",
|
|
].join("\n"),
|
|
);
|
|
expect(reordered.fileType).toBe("2");
|
|
expect(reordered.flags).toEqual(["NOUNDEFS"]);
|
|
const reorderedMultiwordFlags = parseOtoolLoadCommands(
|
|
[
|
|
"Mach header",
|
|
" filetype magic flags ncmds sizeofcmds",
|
|
" 2 0xfeedfacf NOUNDEFS DYLDLINK 0 0",
|
|
].join("\n"),
|
|
);
|
|
expect(reorderedMultiwordFlags.fileType).toBe("2");
|
|
expect(reorderedMultiwordFlags.flags).toEqual(["DYLDLINK", "NOUNDEFS"]);
|
|
expect(() =>
|
|
parseOtoolLoadCommands(
|
|
"Mach header\n magic cputype flags\n 0xfeedfacf 1 NOUNDEFS\n",
|
|
),
|
|
).toThrow(/command framing/u);
|
|
expect(() =>
|
|
parseOtoolLoadCommands(
|
|
"Mach header\n filetype magic flags ncmds sizeofcmds\n 2 0xfeedfacf NOUNDEFS\n",
|
|
),
|
|
).toThrow(/command framing/u);
|
|
});
|
|
|
|
it("rejects duplicate semantic fields, injected sections, and truncated framing", () => {
|
|
const duplicateUuid = withOtoolMachHeader(`Load command 0
|
|
cmd LC_UUID
|
|
cmdsize 24
|
|
uuid 01234567-89ab-cdef-0123-456789abcdef
|
|
uuid fedcba98-7654-3210-fedc-ba9876543210
|
|
`);
|
|
expect(() => parseOtoolLoadCommands(duplicateUuid)).toThrow(/uuid/u);
|
|
|
|
const injectedSection = withOtoolMachHeader(`Load command 0
|
|
cmd LC_SEGMENT_64
|
|
cmdsize 152
|
|
segname __TEXT
|
|
Section
|
|
sectname __fake
|
|
segname __TEXT
|
|
addr 0x1000
|
|
size 0x10
|
|
offset 4096
|
|
align 2^0 (1)
|
|
flags 0x0
|
|
`);
|
|
expect(() => parseOtoolLoadCommands(injectedSection)).toThrow(/vmaddr/u);
|
|
|
|
const incorrectSectionCount = withOtoolMachHeader(`Load command 0
|
|
cmd LC_SEGMENT_64
|
|
cmdsize 152
|
|
segname __TEXT
|
|
vmaddr 0x100000000
|
|
vmsize 0x2000
|
|
fileoff 0
|
|
filesize 8192
|
|
maxprot 0x5
|
|
initprot 0x5
|
|
nsects 0
|
|
flags 0x0
|
|
Section
|
|
sectname __text
|
|
segname __TEXT
|
|
addr 0x100001000
|
|
size 0x100
|
|
offset 4096
|
|
align 4
|
|
flags 0x0
|
|
`);
|
|
expect(() => parseOtoolLoadCommands(incorrectSectionCount)).toThrow(
|
|
/section count/u,
|
|
);
|
|
|
|
const truncatedCount = [
|
|
"Mach header",
|
|
" magic cputype cpusubtype caps filetype ncmds sizeofcmds flags",
|
|
" 0xfeedfacf 16777228 0 0x00 2 2 48 0x00000000",
|
|
"Load command 0",
|
|
" cmd LC_UUID",
|
|
" cmdsize 24",
|
|
" uuid 01234567-89ab-cdef-0123-456789abcdef",
|
|
].join("\n");
|
|
expect(() => parseOtoolLoadCommands(truncatedCount)).toThrow(/count/u);
|
|
|
|
const truncatedBytes = truncatedCount.replace("2 2 48", "2 1 32");
|
|
expect(() => parseOtoolLoadCommands(truncatedBytes)).toThrow(/sizes/u);
|
|
});
|