A missing apktool launcher projected the generic "unavailable for the current target" message and remediation, leaving the actual reason only in details.reason. A relative REA_APKTOOL_COMMAND escaped as UNKNOWN because command selection ran before the try that maps configuration failures. Resolve the selection inside that try for both execution and availability, and pass the refusal reason as userMessage, as JADX and the adapters fixed in #1224 do. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
57 lines
1.9 KiB
TypeScript
57 lines
1.9 KiB
TypeScript
import { expect, it } from "vitest";
|
|
|
|
import { serveCli as serve } from "./cliServeHarness.js";
|
|
|
|
it.each(["inspect-apktool-client", "decode-android-resources"])(
|
|
"%s advertises a schema through the public CLI",
|
|
async (command) => {
|
|
const result = await serve([command, "--schema", "--json"]);
|
|
expect(result.exitCode, command).toBe(0);
|
|
const schema = JSON.parse(result.stdout) as { args?: unknown };
|
|
expect(schema).toBeTruthy();
|
|
},
|
|
);
|
|
|
|
it.each([
|
|
[
|
|
["inspect-apktool-client", "--json"],
|
|
"/nonexistent/apktool",
|
|
"The selected apktool launcher was not found: /nonexistent/apktool. Set REA_APKTOOL_COMMAND",
|
|
],
|
|
[
|
|
["decode-android-resources", "/targets/app.apk", "--json"],
|
|
"/nonexistent/apktool",
|
|
"The selected apktool launcher was not found: /nonexistent/apktool. Set REA_APKTOOL_COMMAND",
|
|
],
|
|
[
|
|
["decode-android-resources", "/targets/app.apk", "--json"],
|
|
"relative/apktool",
|
|
"REA_APKTOOL_COMMAND must be an absolute path to the apktool launcher.",
|
|
],
|
|
])(
|
|
"%j with REA_APKTOOL_COMMAND=%s names the host requirement",
|
|
async (argv, command, reason) => {
|
|
const result = await serve(argv, { REA_APKTOOL_COMMAND: command });
|
|
const output = JSON.parse(result.stdout) as {
|
|
code?: unknown;
|
|
message?: unknown;
|
|
remediation?: { action?: unknown };
|
|
};
|
|
expect(output.code).toBe("capability_unavailable");
|
|
// The target is not the problem; the refusal must say what to configure.
|
|
expect(output.message).toEqual(expect.stringContaining(reason));
|
|
expect(output.remediation?.action).toEqual(expect.stringContaining(reason));
|
|
},
|
|
);
|
|
|
|
it("validates the locale option before launching apktool", async () => {
|
|
const result = await serve([
|
|
"decode-android-resources",
|
|
"/targets/app.apk",
|
|
"--locale",
|
|
"not a locale",
|
|
"--json",
|
|
]);
|
|
expect(result.stdout).toContain("invalid");
|
|
});
|