Files
rea/tests/boundary/providers/hopper/hopperClient.fixture.ts
T
069308bbe6 fix(hopper): preserve startup failures and recover denied launches
Preserve the primary Hopper startup failure and launcher diagnostics while retaining resources when cleanup cannot be confirmed. Reauthenticate matching external application sessions before document cleanup, keep the Python bridge available for bounded reconnects, and expose the provider-owned Hopper startup deadline.

Real headless Linux Hopper semantic analysis and 65 focused configuration, handshake, cleanup, and bridge tests passed. macOS authorization/crash causes and saved-HOP behavior require their own real-provider verification.

Refs #1808

Co-authored-by: N0zoM1z0 <161784452+N0zoM1z0@users.noreply.github.com>
Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com>
2026-10-11 22:35:01 +08:00

136 lines
4.3 KiB
TypeScript

import { spawn, type ChildProcess } from "node:child_process";
import { fileURLToPath } from "node:url";
import { onTestFinished, vi } from "vitest";
import { z } from "zod";
import { ok } from "../../../../src/domain/result.js";
import type {
BridgeLauncher,
BridgeSession,
} from "../../../../src/hopper/BridgeLauncher.js";
import { waitForExit } from "../../../support/process/processFixture.js";
import { HopperClient } from "../../../../src/hopper/HopperClient.js";
export const hopperFixturePath = fileURLToPath(
new URL("../../../fixtures/fakeHopper.mjs", import.meta.url),
);
const requestSchema = z.object({
id: z.number().int(),
method: z.string(),
params: z.record(z.string(), z.unknown()).optional(),
});
type FixtureRequest = z.infer<typeof requestSchema>;
/** Real socket fixture with request acknowledgements and explicit response gates. */
export class HopperFixtureLauncher implements BridgeLauncher {
readonly socketPaths: string[] = [];
readonly directories: string[] = [];
readonly runIds: string[] = [];
readonly tokens: string[] = [];
readonly processes: ChildProcess[] = [];
readonly requests: FixtureRequest[] = [];
constructor(
readonly tokenOverride?: string,
readonly diagnosticMode: "quiet" | "noisy" | "noisy_no_socket" = "quiet",
readonly healthMode: "ready" | "gated" = "ready",
) {}
launch(session: BridgeSession) {
this.socketPaths.push(session.socketPath);
this.directories.push(session.directory);
this.runIds.push(session.runId);
this.tokens.push(session.token);
const child = spawn(
process.execPath,
[
hopperFixturePath,
session.socketPath,
this.tokenOverride ?? session.token,
session.runId,
"acknowledge",
this.diagnosticMode,
this.healthMode,
],
{ stdio: ["ignore", "pipe", "pipe", "ipc"] },
);
child.on("message", (value: unknown) => {
const request = requestSchema.safeParse(value);
if (request.success) this.requests.push(request.data);
});
this.processes.push(child);
return Promise.resolve(
ok({
process: child,
ownsProcessLifetime: true as const,
providerLifetime: "launcher-process" as const,
shutdownMode: "process-cleanup" as const,
cleanup: async () => {
const exited = child.exitCode !== null || child.signalCode !== null;
const signaled = !exited && child.kill("SIGTERM");
return (await waitForExit(child, 5_000))
? { cleaned: true as const, signaled }
: {
cleaned: false as const,
reason: "Fixture process did not exit",
};
},
}),
);
}
/** Wait for acknowledgement that the fixture actually received a request. */
waitForRequest(method: string, gate?: string): Promise<FixtureRequest> {
return vi.waitFor(
() => {
const request = this.requests.find(
(value) =>
value.method === method &&
(gate === undefined || value.params?.gate === gate),
);
if (request === undefined)
throw new Error(`Waiting for Hopper fixture request ${method}`);
return request;
},
{ timeout: 10_000 },
);
}
/** Release a response held by the fixture's gate parameter. */
release(request: FixtureRequest): Promise<void> {
const child = this.processes.at(-1);
if (child === undefined) throw new Error("Hopper fixture was not launched");
return new Promise((resolve, reject) => {
child.send({ release: request.id }, (error) => {
if (error !== null) reject(error);
else resolve();
});
});
}
}
/** Register owned client cleanup before any startup assertion can fail. */
export const trackHopperClient = (client: HopperClient): HopperClient => {
onTestFinished(async () => {
await client.close();
});
return client;
};
/** Start a real fixture session with test-scoped cleanup. */
export const startHopperFixtureClient = async (
launcher = new HopperFixtureLauncher(),
): Promise<HopperClient> => {
const client = trackHopperClient(
new HopperClient({
launcher,
startupTimeoutMs: 10_000,
}),
);
const started = await client.start();
if (!started.ok) throw started.error;
return client;
};