Treat missing, partial, unknown, and unresolved call coverage as insufficient for call-set equality. Combine IDA caller/callee coverage without losing either explanation and recheck source coverage when verifying historical comparisons. Scope generated function-comparison unknowns with optional typed comparison/dimension facts, preserving legacy IDs and revision digests when absent. Keep unrelated dimensions conclusive, explicit dependencies applicable, and ambiguous function identity unknown. A confirmed change for matched functions remains a failure even if calls are incomplete. Validation: function/reconstruction/residual-unknown and bundle tests, recorded IDA protocol regression, public MCP comparison/verification, and advertised SDK JSON Schema checks. Real IDA provider execution was not verified. Fixes #2222
79 lines
2.5 KiB
TypeScript
79 lines
2.5 KiB
TypeScript
import type { RelationshipCoverage } from "./relationshipCoverage.js";
|
|
import type { FunctionDossier } from "./hopperValues.js";
|
|
import { uniqueSorted } from "./canonicalOrdering.js";
|
|
|
|
/** Combine caller and callee read outcomes without losing either explanation. */
|
|
export const combineFunctionRelationshipCoverage = (
|
|
callers: RelationshipCoverage | undefined,
|
|
callees: RelationshipCoverage | undefined,
|
|
): RelationshipCoverage => {
|
|
const reads = [
|
|
{ direction: "callers" as const, coverage: callers },
|
|
{ direction: "callees" as const, coverage: callees },
|
|
];
|
|
const diagnostics = uniqueSorted(
|
|
reads.flatMap(({ coverage }) =>
|
|
coverage !== undefined && "diagnostics" in coverage
|
|
? coverage.diagnostics
|
|
: [],
|
|
),
|
|
);
|
|
const details = diagnostics.length > 0 ? { diagnostics } : {};
|
|
const reasons = reads.flatMap(({ direction, coverage }) => {
|
|
const label = direction === "callers" ? "Callers" : "Callees";
|
|
const limitations =
|
|
coverage === undefined
|
|
? ["Provider did not report relationship coverage."]
|
|
: coverage.status === "unknown"
|
|
? [coverage.reason]
|
|
: coverage.status === "partial"
|
|
? coverage.limitations
|
|
: [];
|
|
return limitations.map((reason) => `${label}: ${reason}`);
|
|
});
|
|
if (
|
|
reads.some(
|
|
({ coverage }) => coverage === undefined || coverage.status === "unknown",
|
|
)
|
|
)
|
|
return {
|
|
status: "unknown",
|
|
reason: uniqueSorted(reasons).join(" "),
|
|
...details,
|
|
};
|
|
if (reasons.length > 0)
|
|
return {
|
|
status: "partial",
|
|
limitations: uniqueSorted(reasons),
|
|
...details,
|
|
};
|
|
return { status: "complete", ...details };
|
|
};
|
|
|
|
/** Explain why two resolved call sets cannot establish call-set equality. */
|
|
export const functionCallCoverageLimitations = (
|
|
coverage: RelationshipCoverage | null,
|
|
dossier: Pick<FunctionDossier, "unresolved_calls">,
|
|
): string[] => {
|
|
const limitations =
|
|
coverage === null
|
|
? ["Provider did not report relationship coverage."]
|
|
: coverage.status === "unknown"
|
|
? [
|
|
coverage.reason,
|
|
...("diagnostics" in coverage ? coverage.diagnostics : []),
|
|
]
|
|
: coverage.status === "partial"
|
|
? [
|
|
...coverage.limitations,
|
|
...("diagnostics" in coverage ? coverage.diagnostics : []),
|
|
]
|
|
: [];
|
|
limitations.push(
|
|
...(dossier.unresolved_calls ?? []).map(
|
|
({ address, reason }) => `Unresolved call at ${address}: ${reason}`,
|
|
),
|
|
);
|
|
return uniqueSorted(limitations);
|
|
};
|