The ADB provider, which the apktool provider mirrors, had the same two defects: a relative REA_ADB_PATH escaped as UNKNOWN because selection ran before the try that maps configuration failures, and a missing adb binary projected generic target advice instead of its reason. Move the configuration-failure-to-refusal mapping into one providerConfigurationRefusal helper used by both providers, resolve the ADB selection inside the mapped try, and share the CLI refusal assertion. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: morluto <76467478+morluto@users.noreply.github.com>
52 lines
1.5 KiB
TypeScript
52 lines
1.5 KiB
TypeScript
import { expect, it } from "vitest";
|
|
|
|
import {
|
|
expectConfigurationRefusal,
|
|
serveCli as serve,
|
|
} from "./cliServeHarness.js";
|
|
|
|
it.each(["inspect-apktool-client", "decode-android-resources"])(
|
|
"%s advertises a schema through the public CLI",
|
|
async (command) => {
|
|
const result = await serve([command, "--schema", "--json"]);
|
|
expect(result.exitCode, command).toBe(0);
|
|
const schema = JSON.parse(result.stdout) as { args?: unknown };
|
|
expect(schema).toBeTruthy();
|
|
},
|
|
);
|
|
|
|
it.each([
|
|
[
|
|
["inspect-apktool-client", "--json"],
|
|
"/nonexistent/apktool",
|
|
"The selected apktool launcher was not found: /nonexistent/apktool. Set REA_APKTOOL_COMMAND",
|
|
],
|
|
[
|
|
["decode-android-resources", "/targets/app.apk", "--json"],
|
|
"/nonexistent/apktool",
|
|
"The selected apktool launcher was not found: /nonexistent/apktool. Set REA_APKTOOL_COMMAND",
|
|
],
|
|
[
|
|
["decode-android-resources", "/targets/app.apk", "--json"],
|
|
"relative/apktool",
|
|
"REA_APKTOOL_COMMAND must be an absolute path to the apktool launcher.",
|
|
],
|
|
])(
|
|
"%j with REA_APKTOOL_COMMAND=%s names the host requirement",
|
|
async (argv, command, reason) => {
|
|
const result = await serve(argv, { REA_APKTOOL_COMMAND: command });
|
|
expectConfigurationRefusal(result, reason);
|
|
},
|
|
);
|
|
|
|
it("validates the locale option before launching apktool", async () => {
|
|
const result = await serve([
|
|
"decode-android-resources",
|
|
"/targets/app.apk",
|
|
"--locale",
|
|
"not a locale",
|
|
"--json",
|
|
]);
|
|
expect(result.stdout).toContain("invalid");
|
|
});
|