Cancelling the macOS process-ownership helper build left swiftc object files in TMPDIR. Node's execFile sends SIGTERM on abort and rejects before the child exits, and swift-driver runs each frontend job in its own process group: on SIGTERM the driver exits while a job keeps writing, so REA removed its root while objects were still being written outside and inside it. Add an opt-in `stopSignal` to execFileOutput that stops the process with the caller's signal on abort or timeout and settles only after it exits. Swift helper builds stop swiftc with SIGINT, on which swift-driver stops its jobs and deletes their objects, and point TMPDIR inside the root cleanup removes. Fixes #1173 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
78 lines
2.5 KiB
TypeScript
78 lines
2.5 KiB
TypeScript
import { mkdir, mkdtemp, rm, symlink } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { SWIFTC_INTERRUPT } from "../process/DarwinProcessRunTokenReader.js";
|
|
import { execFileOutput } from "../process/ExecFileOutput.js";
|
|
import { safeParseJson } from "../domain/safeJson.js";
|
|
import type { NativeUiHelper } from "./NativeUiObservation.js";
|
|
import { NATIVE_UI_HELPER_MAX_BUFFER } from "./NativeUiOutputBudget.js";
|
|
|
|
/** Lazily compile one owned helper per observation/scenario and remove its compiler cache. */
|
|
export const createNativeUiHelperRuntime = () => {
|
|
let root: string | undefined;
|
|
let executable: string | undefined;
|
|
const invoke: NativeUiHelper = async (parameters, signal) => {
|
|
if (executable === undefined) {
|
|
root = await mkdtemp(join(tmpdir(), "rea-native-ui-"));
|
|
const output = join(root, "observer");
|
|
const main = join(root, "main.swift");
|
|
await symlink(
|
|
fileURLToPath(
|
|
new URL("../../bridge/native/ReaNativeUI.swift", import.meta.url),
|
|
),
|
|
main,
|
|
);
|
|
// Keep swiftc's intermediate objects inside the removable root.
|
|
const compilerTemporary = join(root, "tmp");
|
|
await mkdir(compilerTemporary);
|
|
await execFileOutput(
|
|
"/usr/bin/xcrun",
|
|
[
|
|
"swiftc",
|
|
"-module-cache-path",
|
|
join(root, "modules"),
|
|
fileURLToPath(
|
|
new URL(
|
|
"../../bridge/native/NativeUIChildren.swift",
|
|
import.meta.url,
|
|
),
|
|
),
|
|
main,
|
|
"-o",
|
|
output,
|
|
],
|
|
{
|
|
timeout: 60_000,
|
|
maxBuffer: 1024 * 1024,
|
|
stopSignal: SWIFTC_INTERRUPT,
|
|
env: { ...process.env, TMPDIR: compilerTemporary },
|
|
...(signal === undefined ? {} : { signal }),
|
|
},
|
|
);
|
|
executable = output;
|
|
}
|
|
const output = await execFileOutput(
|
|
executable,
|
|
[JSON.stringify(parameters)],
|
|
{
|
|
timeout: 30_000,
|
|
maxBuffer: NATIVE_UI_HELPER_MAX_BUFFER,
|
|
...(signal === undefined ? {} : { signal }),
|
|
},
|
|
);
|
|
const parsed = safeParseJson(output.stdout);
|
|
if (!parsed.ok)
|
|
throw new Error(`Native helper returned invalid JSON: ${parsed.error}`, {
|
|
cause: parsed.cause,
|
|
});
|
|
return parsed.value;
|
|
};
|
|
return {
|
|
invoke,
|
|
close: async () => {
|
|
if (root !== undefined) await rm(root, { recursive: true, force: true });
|
|
},
|
|
};
|
|
};
|