* refactor(test): colocate pure-domain tests and reduce test debt Move focused immutable domain/contracts/adapter tests from tests/composition/** beside their production owners under src/** as colocated *.test.ts/*.fixture.ts, and relocate persistence-shaped composition tests under tests/boundary/filesystem/**. Update import paths, the Vitest project topology (shared worker context for pure domain/contracts and recording-port service projects), the test migration ledger, testing docs, and AGENTS.md to match. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * docs: remove test migration ledger The cutover is complete and the ledger is no longer referenced anywhere in source, scripts, or the docs gate. Drop the standalone artifact. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * docs: clean up stale migration artifacts Remove empty directories left by the test migration and replace the "final cutover" language in docs/testing.md with standing PR guidance that no longer references the completed migration. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> * fix: repair CI failures from schema, knip, and stale generated artifacts Three root causes fixed: 1. catalog-schemas.mjs: valuesAt only traversed anyOf from Zod's toJSONSchema, not oneOf. The webScreenshotDiffSchema change to a discriminated union produces oneOf, so the product catalog generator could not derive the web_screenshot_diff schema version. Add oneOf traversal. 2. conformancePackage.ts: the test rewrite removed the only imports of ScenarioManifest, ReplayPlan, ShimPlan, and ExpectedEvidence, making them unused exports that knip flags. Remove the dead type aliases. 3. Regenerate stale artifacts (product catalog, MCP tool catalog, skill metadata, conformance manifest) that drifted from the source changes. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> --------- Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
119 lines
4.2 KiB
TypeScript
119 lines
4.2 KiB
TypeScript
import { chmod, writeFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
|
|
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
|
|
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
|
|
|
|
import { writeAnalysisSnapshot } from "../../../src/application/AnalysisSnapshotFiles.js";
|
|
import { runDirectAnalysis } from "../../../src/application/DirectAnalysis.js";
|
|
import type { AnalysisSnapshot } from "../../../src/domain/analysisSnapshot.js";
|
|
import {
|
|
snapshotBinding,
|
|
snapshotTarget,
|
|
} from "../../../src/domain/analysisSnapshot.js";
|
|
import { parseBinaryTarget } from "../../../src/domain/binaryTarget.js";
|
|
import { createEvidence } from "../../../src/domain/evidence.js";
|
|
import { createEvidenceBundle } from "../../../src/domain/evidenceBundle.js";
|
|
import { permissionAuthorityForRoot } from "../../fixtures/permissionAuthority.js";
|
|
import {
|
|
REA_WORKFLOW_PROVIDER,
|
|
workflowAnalysisProfile,
|
|
} from "../../../src/application/InvestigationProviders.js";
|
|
import { HOPPER_PROVIDER_IDENTITY } from "../../../src/hopper/HopperProvider.js";
|
|
import { resolveHopperAnalysisProfile } from "../../../src/hopper/HopperAnalysisProfile.js";
|
|
|
|
afterEach(async () => {
|
|
vi.unstubAllEnvs();
|
|
});
|
|
|
|
describe("direct analysis snapshot permissions", () => {
|
|
it("forwards the CLI provider selector ahead of the environment preference", async () => {
|
|
const directory = await createTestTempDirectory("rea-direct-provider-");
|
|
const targetPath = join(directory, "fixture.hop");
|
|
await writeFile(targetPath, "fixture");
|
|
vi.stubEnv("HOPPER_LAUNCHER_PATH", process.execPath);
|
|
vi.stubEnv("REA_ANALYSIS_PROVIDER", "environment-provider");
|
|
|
|
await expect(
|
|
runDirectAnalysis(
|
|
targetPath,
|
|
"binary_overview",
|
|
{},
|
|
{
|
|
providerId: "request-provider",
|
|
},
|
|
),
|
|
).resolves.toMatchObject({
|
|
error: "Analysis failed",
|
|
code: "capability_unavailable",
|
|
details: {
|
|
selection_reason: "unknown_provider",
|
|
requested_provider_id: "request-provider",
|
|
candidate_ids: ["ghidra", "hopper"],
|
|
},
|
|
});
|
|
});
|
|
|
|
it("replays a cache hit with snapshot read authority only", async () => {
|
|
const directory = await createTestTempDirectory("rea-direct-snapshot-");
|
|
const snapshotPath = join(directory, "analysis.json");
|
|
const launcherPath = join(directory, "hopper-launcher");
|
|
await writeFile(launcherPath, "fixture Hopper launcher");
|
|
await chmod(launcherPath, 0o755);
|
|
const target = await parseBinaryTarget(process.execPath);
|
|
if (!target.ok) throw target.error;
|
|
const resolved = await resolveHopperAnalysisProfile(target.value, {
|
|
launcherPath,
|
|
loaderArgsOverride: [],
|
|
provider: HOPPER_PROVIDER_IDENTITY,
|
|
});
|
|
if (!resolved.ok || resolved.value.profile === null)
|
|
throw new Error("fixture Hopper profile did not resolve");
|
|
const profile = resolved.value.profile;
|
|
const workflowProfile = workflowAnalysisProfile(profile);
|
|
const evidence = createEvidence(target.value, REA_WORKFLOW_PROVIDER, {
|
|
operation: "binary_overview",
|
|
parameters: {},
|
|
result: { cached: true },
|
|
analysisProfile: workflowProfile,
|
|
});
|
|
const snapshot: AnalysisSnapshot = {
|
|
snapshot_version: 2,
|
|
target: snapshotTarget(target.value),
|
|
binding: snapshotBinding(profile),
|
|
entries: [],
|
|
evidence_bundle: createEvidenceBundle([evidence]),
|
|
};
|
|
const policy = {
|
|
roots: [directory],
|
|
maxBytes: 1024 * 1024,
|
|
maxDepth: 64,
|
|
maxStringLength: 1024,
|
|
maxNodes: 10_000,
|
|
};
|
|
expect(
|
|
(await writeAnalysisSnapshot(snapshot, snapshotPath, false, policy)).ok,
|
|
).toBe(true);
|
|
const authority = await permissionAuthorityForRoot(
|
|
directory,
|
|
["snapshot_read", "snapshot_write"],
|
|
["snapshot_read"],
|
|
);
|
|
vi.stubEnv("REA_ANALYSIS_SNAPSHOT_ROOTS_JSON", JSON.stringify([directory]));
|
|
vi.stubEnv("HOPPER_LAUNCHER_PATH", launcherPath);
|
|
|
|
await expect(
|
|
runDirectAnalysis(
|
|
process.execPath,
|
|
"binary_overview",
|
|
{},
|
|
{
|
|
snapshotPath,
|
|
permissionAuthority: authority,
|
|
},
|
|
),
|
|
).resolves.toEqual(evidence);
|
|
});
|
|
});
|