## Changes Related to #545 and the permission-system removal in #555. - Upgrade the shipped skill to v24 and remove obsolete filesystem grants, per-call approval flags, Electron file-root configuration, and DMG approval flags. Calls follow the user-requested investigation directly. Keep setup plan confirmation, actual OS requirements, and process/archive lifecycle boundaries. - Correct the passive browser guide: endpoint/scope come from requests; ordinary local URL queries are retained, while credentials remain redacted. - Audit canonical tool effects: declare possible DMG process/temp-directory effects, mark fresh extraction non-idempotent, and mark comparisons of supplied captures/PNGs as closed-world. Align artifact-provider capability effects with temporary mount-directory writes. - Retain non-read-only hints for calls that add Evidence to the session; document that annotations are hints and that clients control their confirmation UI. Do not mislabel session mutations as read-only to suppress prompts. - Regenerate package, skill, MCP, and product metadata from source. ## Verification - `npm run test:focused -- <11 affected test files>`: **40 tests passed**, including skill transaction/backup/idempotence, SDK tools/list annotations, actual local capture/PNG comparisons, artifact extraction/containment/cancellation, DMG launcher/cleanup seam, setup confirmation, browser MCP and scenario MCP, CLI catalog parity. - `npm run check`: typecheck, lint, format, knip, package metadata. - `npm run docs:check`: generated catalogs, skill metadata, documentation facts, completion ledger, error schema. No local real Hopper/Ghidra run: their adapters and analysis operations are unchanged. Native macOS DMG behavior is covered locally through the launcher seam; no local macOS/hdiutil claim is made. Real browser verification passed using existing Headless Chrome143.0.7499.4: actual CLI/stdio MCP,9,331,407-byte PNG, passive capture/source maps, and owned/external scenario cleanup. An initial full Chrome143 run failed the existing screenshot-height assertion (1397 versus1536); the dedicated headless-shell run passed the complete verifier without code changes. The verifier run-lineage field remained unavailable; no lineage-coverage claim is made. Browser download into `.codex` was blocked by CDN403, so the successful run used an existing browser without changing host configuration.
157 lines
5.3 KiB
TypeScript
157 lines
5.3 KiB
TypeScript
import { access, mkdir, readFile, readdir, writeFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
import { createTestTempDirectory } from "../../../fixtures/temporaryDirectory.js";
|
|
|
|
import { ArtifactProvider } from "../../../../src/artifacts/ArtifactProvider.js";
|
|
import { artifactExtractionExecutionSchema } from "../../../../src/contracts/artifactToolContracts.js";
|
|
import { TOOL_EFFECTS } from "../../../../src/contracts/toolEffects.js";
|
|
import {
|
|
artifactExtractionResultSchema,
|
|
artifactInventoryResultSchema,
|
|
} from "../../../../src/domain/artifactGraph.js";
|
|
import type { BinaryTarget } from "../../../../src/domain/binaryTarget.js";
|
|
|
|
describe("artifact extraction", () => {
|
|
it("declares possible native mounts and fresh extraction directories", () => {
|
|
for (const platform of ["linux", "darwin"] as const) {
|
|
const provider = new ArtifactProvider(platform);
|
|
for (const operation of [
|
|
"inventory_artifact",
|
|
"inspect_artifact",
|
|
"extract_artifact",
|
|
] as const) {
|
|
expect(
|
|
provider
|
|
.capabilities()
|
|
.find((capability) => capability.operation === operation)?.effects,
|
|
).toMatchObject({ launchesProcess: true, mayWriteFilesystem: true });
|
|
}
|
|
}
|
|
expect(TOOL_EFFECTS.inspect_artifact).toMatchObject({
|
|
launchesProcess: true,
|
|
writesFilesystem: true,
|
|
mutatesTarget: false,
|
|
});
|
|
expect(TOOL_EFFECTS.extract_artifact).toMatchObject({
|
|
launchesProcess: true,
|
|
writesFilesystem: true,
|
|
idempotent: false,
|
|
mutatesTarget: false,
|
|
});
|
|
});
|
|
it("extracts all regular occurrences through an exclusively owned output tree", async () => {
|
|
const root = await createTestTempDirectory("rea-extract-");
|
|
const source = join(root, "source");
|
|
await mkdir(join(source, "assets"), { recursive: true });
|
|
await writeFile(join(source, "assets", "selected.js"), "selected();\n");
|
|
await writeFile(join(source, "assets", "ignored.js"), "ignored();\n");
|
|
const targetValue = target(source, "directory");
|
|
const graph = await inventory(targetValue);
|
|
expect(
|
|
graph.occurrences.some(
|
|
({ logical_path }) => logical_path === "assets/selected.js",
|
|
),
|
|
).toBe(true);
|
|
const cancelledOutput = join(root, "cancelled-output");
|
|
const controller = new AbortController();
|
|
controller.abort();
|
|
const cancelled = await new ArtifactProvider()
|
|
.createClient(targetValue)
|
|
.execute(
|
|
"extract_artifact",
|
|
artifactExtractionExecutionSchema.parse({
|
|
output_root: cancelledOutput,
|
|
}),
|
|
{ signal: controller.signal },
|
|
);
|
|
expect(cancelled).toMatchObject({
|
|
ok: false,
|
|
error: { _tag: "ArtifactOperationError", reason: "cancelled" },
|
|
});
|
|
await expect(access(cancelledOutput)).rejects.toThrow();
|
|
const output = join(root, "output");
|
|
const result = await new ArtifactProvider()
|
|
.createClient(targetValue)
|
|
.execute(
|
|
"extract_artifact",
|
|
artifactExtractionExecutionSchema.parse({
|
|
output_root: output,
|
|
}),
|
|
);
|
|
expect(result.ok).toBe(true);
|
|
if (!result.ok) return;
|
|
const firstExtraction = artifactExtractionResultSchema.parse(
|
|
result.value.result,
|
|
);
|
|
expect(firstExtraction).toMatchObject({
|
|
output_root: output,
|
|
containment_verified: true,
|
|
artifacts: expect.arrayContaining([
|
|
expect.objectContaining({ relative_path: "assets/selected.js" }),
|
|
]),
|
|
extraction_manifest: { output_root_alias: "$OUTPUT_ROOT" },
|
|
});
|
|
expect(await readFile(join(output, "assets", "selected.js"), "utf8")).toBe(
|
|
"selected();\n",
|
|
);
|
|
expect(await readFile(join(output, "assets", "ignored.js"), "utf8")).toBe(
|
|
"ignored();\n",
|
|
);
|
|
|
|
const relocatedOutput = join(root, "relocated-output");
|
|
const relocated = await new ArtifactProvider()
|
|
.createClient(targetValue)
|
|
.execute(
|
|
"extract_artifact",
|
|
artifactExtractionExecutionSchema.parse({
|
|
output_root: relocatedOutput,
|
|
}),
|
|
);
|
|
expect(relocated.ok).toBe(true);
|
|
if (!relocated.ok) return;
|
|
expect(
|
|
artifactExtractionResultSchema.parse(relocated.value.result)
|
|
.extraction_manifest,
|
|
).toEqual(firstExtraction.extraction_manifest);
|
|
|
|
const second = await new ArtifactProvider()
|
|
.createClient(targetValue)
|
|
.execute(
|
|
"extract_artifact",
|
|
artifactExtractionExecutionSchema.parse({
|
|
output_root: output,
|
|
}),
|
|
);
|
|
expect(second).toMatchObject({
|
|
ok: false,
|
|
error: { _tag: "ArtifactOperationError", reason: "path" },
|
|
});
|
|
expect((await readdir(root)).sort()).toEqual([
|
|
"output",
|
|
"relocated-output",
|
|
"source",
|
|
]);
|
|
});
|
|
});
|
|
const inventory = async (targetValue: BinaryTarget) => {
|
|
const result = await new ArtifactProvider()
|
|
.createClient(targetValue)
|
|
.execute("inventory_artifact", {});
|
|
if (!result.ok) throw result.error;
|
|
return artifactInventoryResultSchema.parse(result.value.result);
|
|
};
|
|
|
|
const target = (
|
|
path: string,
|
|
format: Extract<BinaryTarget, { kind: "archive" }>["format"] | "directory",
|
|
): BinaryTarget => ({
|
|
path,
|
|
sourcePath: path,
|
|
sha256: "0".repeat(64),
|
|
kind: "archive",
|
|
format: format === "directory" ? "asar" : format,
|
|
});
|