Artifact path failures told callers to "inspect the reported path" but
reported none: `ArtifactReaderFailure` messages such as
`Artifact path collision: ...` were dropped when converted to
`ArtifactOperationError`, leaving only `{ operation, reason: "path" }`.
Carry the failure message into `details.detail` for artifact tools and
JavaScript application analysis. Name both spellings in case-fold
collisions and include the JSON-escaped input in unsafe and
non-normalized path messages.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
36 lines
1.4 KiB
TypeScript
36 lines
1.4 KiB
TypeScript
import { join } from "node:path";
|
|
|
|
import { expect, it } from "vitest";
|
|
|
|
import { writeOrderedZip } from "../../../fixtures/artifactEntryOrder.js";
|
|
import { createTestTempDirectory } from "../../../fixtures/temporaryDirectory.js";
|
|
|
|
import { parseBinaryTarget } from "../../../../src/application/BinaryTargetResolver.js";
|
|
import { ArtifactProvider } from "../../../../src/artifacts/ArtifactProvider.js";
|
|
import { projectAnalysisError } from "../../../../src/domain/analysisErrorProjection.js";
|
|
|
|
it.each([
|
|
[
|
|
["Main.js", "main.js"],
|
|
"Artifact path collision: main.js differs only in case from Main.js",
|
|
],
|
|
[["a\\b.js"], 'Artifact path is absolute or unsafe: "a\\\\b.js"'],
|
|
] as const)(
|
|
"reports the failed path constraint for %j",
|
|
async (entries, detail) => {
|
|
const root = await createTestTempDirectory("rea-artifact-detail-");
|
|
const path = join(root, "fixture.zip");
|
|
await writeOrderedZip(path, entries);
|
|
const target = await parseBinaryTarget(path);
|
|
if (!target.ok) throw new Error("expected a ZIP target");
|
|
const result = await new ArtifactProvider()
|
|
.createClient(target.value)
|
|
.execute("inventory_artifact", {});
|
|
if (result.ok) throw new Error("expected the path constraint to fail");
|
|
expect(projectAnalysisError(result.error)).toMatchObject({
|
|
code: "artifact_operation_failed",
|
|
details: { operation: "inventory_artifact", reason: "path", detail },
|
|
});
|
|
},
|
|
);
|