migration: preserve sentiment and pools slice

2026-07-31 01:41:58 +08:00
parent a4264326bd
commit b3555d2603
19 changed files with 956 additions and 696 deletions
@@ -0,0 +1,114 @@
+from __future__ import annotations
+
+import ast
+import hashlib
+import unittest
+from pathlib import Path
+
+import sentiment_engine
+from backend.features.sentiment import engine as canonical_engine
+
+
+APP_ROOT = Path(__file__).resolve().parents[1]
+ORIGINAL_ROOT = APP_ROOT.parent
+
+SENTIMENT_METHODS = {
+    "_enrich_dashboard_sentiment",
+    "sentiment_history",
+}
+POOL_METHODS = {
+    "save_reason",
+    "_apply_reason_overrides",
+    "_schedule_ifind_event_enrichment",
+    "_refresh_ifind_event_enrichment",
+    "_normalize_ifind_event_time",
+    "_merge_ifind_event_enrichment",
+}
+POOL_REPOSITORY_METHODS = {
+    "save_reason_override",
+    "reason_overrides",
+}
+
+
+def class_methods(path: Path, class_name: str) -> dict[str, str]:
+    tree = ast.parse(path.read_text(encoding="utf-8"), filename=str(path))
+    owner = next(
+        node
+        for node in tree.body
+        if isinstance(node, ast.ClassDef) and node.name == class_name
+    )
+    return {
+        node.name: ast.dump(node, include_attributes=False)
+        for node in owner.body
+        if isinstance(node, (ast.FunctionDef, ast.AsyncFunctionDef))
+    }
+
+
+def sha256(path: Path) -> str:
+    return hashlib.sha256(path.read_bytes()).hexdigest()
+
+
+class SentimentPoolSliceSourceEquivalenceTests(unittest.TestCase):
+    def test_sentiment_service_methods_are_exact_original_ast(self) -> None:
+        original = class_methods(ORIGINAL_ROOT / "server.py", "DashboardService")
+        migrated = class_methods(
+            APP_ROOT / "backend" / "features" / "sentiment" / "service.py",
+            "SentimentServiceMixin",
+        )
+        self.assertEqual(set(migrated), SENTIMENT_METHODS)
+        for name in sorted(SENTIMENT_METHODS):
+            self.assertEqual(migrated[name], original[name], name)
+
+    def test_pool_service_methods_are_exact_original_ast(self) -> None:
+        original = class_methods(ORIGINAL_ROOT / "server.py", "DashboardService")
+        migrated = class_methods(
+            APP_ROOT / "backend" / "features" / "pools" / "service.py",
+            "PoolServiceMixin",
+        )
+        self.assertEqual(set(migrated), POOL_METHODS)
+        for name in sorted(POOL_METHODS):
+            self.assertEqual(migrated[name], original[name], name)
+
+    def test_pool_repository_methods_are_exact_original_ast(self) -> None:
+        original = class_methods(ORIGINAL_ROOT / "database.py", "ReviewDatabase")
+        migrated = class_methods(
+            APP_ROOT / "backend" / "features" / "pools" / "repository.py",
+            "PoolRepositoryMixin",
+        )
+        self.assertEqual(set(migrated), POOL_REPOSITORY_METHODS)
+        for name in sorted(POOL_REPOSITORY_METHODS):
+            self.assertEqual(migrated[name], original[name], name)
+
+    def test_original_classes_no_longer_duplicate_moved_methods(self) -> None:
+        remaining_service = class_methods(
+            APP_ROOT / "backend" / "application.py", "DashboardService"
+        )
+        remaining_database = class_methods(APP_ROOT / "database.py", "ReviewDatabase")
+        self.assertTrue((SENTIMENT_METHODS | POOL_METHODS).isdisjoint(remaining_service))
+        self.assertTrue(POOL_REPOSITORY_METHODS.isdisjoint(remaining_database))
+
+    def test_sentiment_engine_is_exact_original_with_legacy_alias(self) -> None:
+        self.assertEqual(
+            sha256(ORIGINAL_ROOT / "sentiment_engine.py"),
+            sha256(APP_ROOT / "backend" / "features" / "sentiment" / "engine.py"),
+        )
+        self.assertIs(sentiment_engine, canonical_engine)
+
+    def test_api_and_frontend_assets_are_unchanged(self) -> None:
+        for relative in (
+            "config/api.config.json",
+            "static/index.html",
+            "static/app.js",
+            "static/styles.css",
+            "static/pages/sentiment/page.js",
+            "static/pages/pools/page.js",
+        ):
+            self.assertEqual(
+                sha256(APP_ROOT / relative),
+                sha256(ORIGINAL_ROOT / relative),
+                relative,
+            )
+
+
+if __name__ == "__main__":
+    unittest.main()