feat: add visual settings and readiness gate

services/api/app/integrations/storage.py

@@ -1,4 +1,6 @@
 from dataclasses import dataclass
+from collections.abc import Mapping
+from typing import Any
 
 import boto3
 from botocore.client import Config
@@ -15,33 +17,38 @@ class PresignedUpload:
 
 
 class S3Storage:
-    def __init__(self, settings: Settings) -> None:
+    def __init__(self, settings: Settings | Mapping[str, Any]) -> None:
         self.settings = settings
 
+    def _value(self, key: str, default: Any = "") -> Any:
+        if isinstance(self.settings, Mapping):
+            return self.settings.get(key, default)
+        return getattr(self.settings, key, default)
+
     @property
     def configured(self) -> bool:
         values = (
-            self.settings.s3_endpoint,
-            self.settings.s3_access_key_id,
-            self.settings.s3_secret_access_key,
+            self._value("s3_endpoint"),
+            self._value("s3_access_key_id"),
+            self._value("s3_secret_access_key"),
         )
         return all(values) and not any(value.startswith("replace_with_") for value in values)
 
     def _client(self, public: bool = False):
         endpoint = (
-            self.settings.s3_public_endpoint
-            if public and self.settings.s3_public_endpoint
-            else self.settings.s3_endpoint
+            self._value("s3_public_endpoint")
+            if public and self._value("s3_public_endpoint")
+            else self._value("s3_endpoint")
         )
         return boto3.client(
             "s3",
             endpoint_url=endpoint,
-            aws_access_key_id=self.settings.s3_access_key_id,
-            aws_secret_access_key=self.settings.s3_secret_access_key,
-            region_name=self.settings.s3_region,
+            aws_access_key_id=self._value("s3_access_key_id"),
+            aws_secret_access_key=self._value("s3_secret_access_key"),
+            region_name=self._value("s3_region", "us-east-1"),
             config=Config(
                 signature_version="s3v4",
-                s3={"addressing_style": "path" if self.settings.s3_force_path_style else "auto"},
+                s3={"addressing_style": "path" if self._value("s3_force_path_style", True) else "auto"},
             ),
         )
 
@@ -51,15 +58,15 @@ class S3Storage:
         url = self._client(public=True).generate_presigned_url(
             "put_object",
             Params={
-                "Bucket": self.settings.s3_bucket_inputs,
+                "Bucket": self._value("s3_bucket_inputs"),
                 "Key": object_key,
                 "ContentType": content_type,
             },
-            ExpiresIn=self.settings.s3_presigned_url_ttl_seconds,
+            ExpiresIn=int(self._value("s3_presigned_url_ttl_seconds", 900)),
         )
         return PresignedUpload(
             method="PUT",
             url=url,
             object_key=object_key,
-            expires_in=self.settings.s3_presigned_url_ttl_seconds,
+            expires_in=int(self._value("s3_presigned_url_ttl_seconds", 900)),
         )