HEL-897: record bytewise preservation and independent regression checks
Co-authored-by: multica-agent <github@multica.ai>
This commit is contained in:
@@ -0,0 +1,13 @@
|
||||
# HEL-897 MANIFEST
|
||||
|
||||
Base: HEL-878 author draft as preserved by the supervisor, b95ce798b4a9455d941d247a46865b3ac202bf2c (13 files verified against preservation-878.json before work). Patch is relative to that tree; full tree (no node_modules/dist) in HEL-897-source.zip. Nothing else changed; HEL-878 files and handoff-HEL-878.json untouched except the two test helpers listed below.
|
||||
|
||||
## Changed/added files (sha256)
|
||||
- docs/requirements/handoff-HEL-897.json 56CF0E97B5035CCFAAFF3F7DD219CA30352DF600FA4C9684EB690E4E44731BC9
|
||||
- web/src/voice/session.ts 4B74731B7DC34534FF8F046B9487E115B3A38CFB202B045E34A12FA27FE528FE
|
||||
- web/tests/hel878_mock.mjs 1B1608D5E0858842E9A0CF51FAAF9BAECE5E52B546757464B046DF0E66A4B815
|
||||
- web/tests/hel878_shots.mjs E5706C5A4459315ECDB991CBD8D3776DB3EFE035FE520930FFB09E726EB639C7
|
||||
- web/tests/review878_late_cleanup.test.ts 65261CD249A36693D0C6B06CE279DE8A60AA74DD7BAAFAD6999D2FEC790F9935
|
||||
- web/tests/voice.test.ts 4C120B9449CE3AF0B66B3B8A18668D5012D286D6C18C0DEE1347A880F7780471
|
||||
|
||||
HEL-897.patch 1D8C43B0FE9984066406E60FAC715764DCD375546713DEB6BD034160F2050070
|
||||
@@ -0,0 +1,18 @@
|
||||
HEL-897 返修保全与独立补查(总管,2026-10-27 北京时间)
|
||||
|
||||
原作者交付评论:01a1798b-60b0-7562-9a70-82584f52dd54;主卡 HEL-797。需求 v1.11 / 60项,无需求变更。关联 CG-010/018、VIS-013、UX-005/006、GOV-001–006、DEL-001。
|
||||
|
||||
本次原样保全提交:761a2331f5898bacada8d9665da517c816af2367;作者原稿基点 b95ce798b4a9455d941d247a46865b3ac202bf2c,实际追加基点 f259bd34e19959db210578b11076e6f29a6bd15e。仅作者补丁所列6文件,业务代码仅 web/src/voice/session.ts;未改视觉、后台或HEL-896。补丁哈希及6文件SHA-256与独立MANIFEST、源码包逐字节匹配,git apply反向检查通过;总管负例与上一轮文件逐字节一致。源码包其余127文件经CRLF/LF规范化匹配;源码包携带旧source-manifest,按作者交接保留实际分支从04eff611补全的版本,逐字节核对未回退。另在本记录及preservation.json保存证据,不改作者handoff中的历史未测记录。
|
||||
|
||||
独立实际执行:
|
||||
|
||||
- 使用相同的33项语音测试,仅将隔离副本session.ts替换为b95ce798原版:5失败/28通过。原负例仍为Expected listening / Received off;交错start负例有两间未释放房间。
|
||||
- 修后完整8文件88/88单测通过(包含上述33项)。typecheck通过;lint 0错/1条既有警告;build通过。沿用同锁文件的本机既有node_modules复制树,没有安装或下载。
|
||||
- Python原版scripts/check_requirements.py:对origin/main、实际总装origin/hel-870-assembly(04eff611)、后台origin/agent/2/6a08a4c18f23(aba2aeb)、本次实际追加目标origin/hel-878-voice-wiring(f259bd3),各不带handoff、带handoff-HEL-878、带handoff-HEL-897,共12次通过。各精确提交在preservation.json。
|
||||
- 作者的无头Edge浏览器49/49及修前45/49已随卡交证据;本轮未独立复跑浏览器,不把它当真WebRTC、真实麦克风或真机证据。
|
||||
|
||||
代码核对:fail同步让出旧会话所有权,启动仅清旧资源的teardown后立即提交本次OFF提示,清理等待后不再提交状态;start在await前取得代次,清理旧会话后先核对是否过期。负例与新增回归覆盖迟到DELETE/settle、掉线、撤销权限、worker超时、正常结束慢DELETE、交错start和迟到麦克风授权;原旧会话资源与新会话存活断言保持。
|
||||
|
||||
本次有限返修可交HEL-879独立统一审核,不代表完整R5通过。完整需求原话已核对R5/D1/D3、视觉分工、动态认可、成熟复用、完整体验指令;CG-011主动开口仍为后台no-op、增量字幕仍缺,须列有限接缝修正;真实远端断线清理/租约/API重启、SDK回调和播放回执、真实三轮/打断/停麦/HTTPS/WSS/Safari全未测。R6/R7、CG-028/029继续主卡承接。
|
||||
|
||||
推进顺序:总工HEL-896仍在运行,不能并行修改其母线;HEL-879接到此保全候选后,待HEL-896交回且总管核对实际母线再启动统一审核,避免覆盖新预算/发布成果。真实调用、音色、设备路径、预算和部署仍按主卡最终批准,默认真实cap=0。不合并、不部署、不碰旧服务/档案/凭据/运行时绑定。
|
||||
@@ -0,0 +1,43 @@
|
||||
{
|
||||
"author_comment": "01a1798b-60b0-7562-9a70-82584f52dd54",
|
||||
"baseline_version": "1.11",
|
||||
"author_base": "b95ce798b4a9455d941d247a46865b3ac202bf2c",
|
||||
"applied_to": "f259bd34e19959db210578b11076e6f29a6bd15e",
|
||||
"patch_sha256": "1d8c43b0fe9984066406e60fac715764dcd375546713deb6bd034160f2050070",
|
||||
"files": [
|
||||
{
|
||||
"path": "docs/requirements/handoff-HEL-897.json",
|
||||
"sha256": "56cf0e97b5035ccfaaff3f7dd219ca30352df600fa4c9684eb690e4e44731bc9"
|
||||
},
|
||||
{
|
||||
"path": "web/src/voice/session.ts",
|
||||
"sha256": "4b74731b7dc34534ff8f046b9487e115b3a38cfb202b045e34a12fa27fe528fe"
|
||||
},
|
||||
{
|
||||
"path": "web/tests/hel878_mock.mjs",
|
||||
"sha256": "1b1608d5e0858842e9a0cf51faaf9baece5e52b546757464b046df0e66a4b815"
|
||||
},
|
||||
{
|
||||
"path": "web/tests/hel878_shots.mjs",
|
||||
"sha256": "e5706c5a4459315ecdb991cbd8d3776db3efe035fe520930ffb09e726eb639c7"
|
||||
},
|
||||
{
|
||||
"path": "web/tests/review878_late_cleanup.test.ts",
|
||||
"sha256": "65261cd249a36693d0c6b06ce279de8a60aa74dd7baafad6999d2fec790f9935"
|
||||
},
|
||||
{
|
||||
"path": "web/tests/voice.test.ts",
|
||||
"sha256": "4c120b9449ce3af0b66b3b8a18668d5012d286d6c18c0dee1347a880f7780471"
|
||||
}
|
||||
],
|
||||
"archive_other_files_matched_normalized_lf": 127,
|
||||
"archive_extras": [],
|
||||
"source_manifest": "archive retains older manifest; actual branch retains 04eff611 authoritative manifest as author instructed; bytewise verified",
|
||||
"preserved_commit": "761a2331f5898bacada8d9665da517c816af2367",
|
||||
"requirement_ref_commits": {
|
||||
"origin/main": "3a986726d8593e0ed2274f79db6cc5d807d2ebf0",
|
||||
"origin/hel-870-assembly": "04eff611e7d85e539d43717711172441420ac853",
|
||||
"origin/agent/2/6a08a4c18f23": "aba2aebeb08d87854b5b037b5e69d76ddfba446e",
|
||||
"origin/hel-878-voice-wiring": "f259bd34e19959db210578b11076e6f29a6bd15e"
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,159 @@
|
||||
|
||||
RUN v3.1.2 /home/xiaomo/multica_workspaces/hello-af23464d222e/hel-897-cfe565d5b1bd/workdir/baseline-web
|
||||
|
||||
❯ tests/review878_late_cleanup.test.ts (1 test | 1 failed) 12ms
|
||||
× old room disconnect cleanup cannot overwrite a newly opened call 11ms
|
||||
→ expected 'off' to be 'listening' // Object.is equality
|
||||
❯ tests/voice.test.ts (32 tests | 4 failed) 49ms
|
||||
✓ honest switch > reads status only: no room, no microphone 4ms
|
||||
✓ honest switch > configured && tts_ok never means "verified": voice:false is not read as connected 1ms
|
||||
✓ honest switch > refuses honestly before touching the microphone when the server cannot speak 1ms
|
||||
✓ honest switch > an insecure page is told why, without asking for the microphone 0ms
|
||||
✓ lifecycle > opens, joins, publishes the microphone, follows her state; ending stops everything 1ms
|
||||
✓ lifecycle > permission denied: nothing opened on the server, nothing left running 1ms
|
||||
✓ lifecycle > server refusal shows its own words and releases the microphone 0ms
|
||||
✓ lifecycle > a failed join releases the microphone and gives the room back 0ms
|
||||
✓ lifecycle > ending while the microphone prompt is open: the late microphone is stopped, no room is asked for 2ms
|
||||
✓ lifecycle > ending while the room is being opened: the late grant is given back, never joined 3ms
|
||||
✓ lifecycle > ending while joining: the join is aborted, a late room is closed, the server room deleted 3ms
|
||||
✓ lifecycle > rapid on/off/on: only the last call stays, every earlier microphone and room is released 3ms
|
||||
✓ lifecycle > late events from an ended call never bring it back 2ms
|
||||
✓ lifecycle > the room dropping on its own (network, server ended it) cleans up and says so 1ms
|
||||
✓ lifecycle > microphone permission revoked mid-call ends the call 1ms
|
||||
✓ lifecycle > her worker never joining is a failure, not an endless wait 2ms
|
||||
✓ lifecycle > offline ends with its own words; unload releases at once and the DELETE survives the page 2ms
|
||||
✓ lifecycle > a DELETE that cannot get through (offline) is owed, survives a new page, and is sent once back online 1ms
|
||||
✓ lifecycle > an owed room already gone on the server (404) counts as settled 0ms
|
||||
✓ lifecycle > never confirms a receipt or posts chat itself: the worker owns both 0ms
|
||||
× a late end of an older call > the room dropped, its DELETE (and the settle retry) answering after a new call is up, leaves the new call alone 6ms
|
||||
→ expected { phase: 'listening', heard: '', …(3) } to match object { phase: 'off' }
|
||||
(4 matching properties omitted from actual)
|
||||
× a late end of an older call > the microphone was taken away, its DELETE (and the settle retry) answering after a new call is up, leaves the new call alone 2ms
|
||||
→ expected { phase: 'listening', heard: '', …(3) } to match object { phase: 'off' }
|
||||
(4 matching properties omitted from actual)
|
||||
× a late end of an older call > her worker never joined, the DELETE is slow, and a new call is started before it answers 1ms
|
||||
→ expected { phase: 'joining', heard: '', …(3) } to match object { phase: 'off', …(1) }
|
||||
(3 matching properties omitted from actual)
|
||||
✓ a late end of an older call > a normal end whose DELETE is slow, then a new call, then the old answer arrives 2ms
|
||||
× a late end of an older call > starting again while the previous start still waits for the old room to be given back: only the newest call survives 5ms
|
||||
→ expected [ Room{ closed: +0, …(3) }, …(1) ] to deeply equal [ Room{ closed: +0, …(3) } ]
|
||||
✓ a late end of an older call > a microphone granted late to an older start is stopped without touching the new call 3ms
|
||||
✓ subtitles and the two channels > interim is a draft; user_final cancels a text reply and asks for the record; φ is heard but not recorded 0ms
|
||||
✓ subtitles and the two channels > without the agent state attribute, subtitles still move the state honestly 0ms
|
||||
✓ subtitles and the two channels > typing over her spoken answer silences what is left of it until she is listening again 0ms
|
||||
✓ record re-read > adds voice turns once, in id order; leaves reach-outs to the inbox and text turns to the stream 0ms
|
||||
✓ record re-read > a pending voice row settles in place (sent or cancelled), never duplicated 0ms
|
||||
✓ record re-read > reads newest pages down to what the page holds, bounded 1ms
|
||||
|
||||
Test Files 2 failed (2)
|
||||
Tests 5 failed | 28 passed (33)
|
||||
Start at 02:51:41
|
||||
Duration 268ms (transform 81ms, setup 0ms, collect 150ms, tests 61ms, environment 0ms, prepare 76ms)
|
||||
|
||||
|
||||
⎯⎯⎯⎯⎯⎯⎯ Failed Tests 5 ⎯⎯⎯⎯⎯⎯⎯
|
||||
|
||||
FAIL tests/review878_late_cleanup.test.ts > old room disconnect cleanup cannot overwrite a newly opened call
|
||||
AssertionError: expected 'off' to be 'listening' // Object.is equality
|
||||
|
||||
Expected: "listening"
|
||||
Received: "off"
|
||||
|
||||
❯ tests/review878_late_cleanup.test.ts:39:29
|
||||
37| await new Promise(resolve => setTimeout(resolve, 0));
|
||||
38| expect(controller.active).toBe(true);
|
||||
39| expect(view?.phase).toBe('listening');
|
||||
| ^
|
||||
40| } finally {
|
||||
41| releaseOld();
|
||||
|
||||
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/5]⎯
|
||||
|
||||
FAIL tests/voice.test.ts > a late end of an older call > the room dropped, its DELETE (and the settle retry) answering after a new call is up, leaves the new call alone
|
||||
FAIL tests/voice.test.ts > a late end of an older call > the microphone was taken away, its DELETE (and the settle retry) answering after a new call is up, leaves the new call alone
|
||||
AssertionError: expected { phase: 'listening', heard: '', …(3) } to match object { phase: 'off' }
|
||||
(4 matching properties omitted from actual)
|
||||
|
||||
- Expected
|
||||
+ Received
|
||||
|
||||
{
|
||||
- "phase": "off",
|
||||
+ "phase": "listening",
|
||||
}
|
||||
|
||||
❯ tests/voice.test.ts:274:30
|
||||
272| const r = await connected(), slow = hold(r, 's1');
|
||||
273| cause(r); await flush();
|
||||
274| expect(r.view()).toMatchObject({ phase: 'off' });
|
||||
| ^
|
||||
275| expect(r.transport.mics[0].stopped).toBeGreaterThan(0); …
|
||||
276| expect(r.c.active).toBe(false);
|
||||
|
||||
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/5]⎯
|
||||
|
||||
FAIL tests/voice.test.ts > a late end of an older call > her worker never joined, the DELETE is slow, and a new call is started before it answers
|
||||
AssertionError: expected { phase: 'joining', heard: '', …(3) } to match object { phase: 'off', …(1) }
|
||||
(3 matching properties omitted from actual)
|
||||
|
||||
- Expected
|
||||
+ Received
|
||||
|
||||
{
|
||||
- "notice": "她没有接上这次通话,麦克风已经关闭。文字仍可使用。",
|
||||
- "phase": "off",
|
||||
+ "notice": "",
|
||||
+ "phase": "joining",
|
||||
}
|
||||
|
||||
❯ tests/voice.test.ts:293:26
|
||||
291| const r = rig(); await r.c.start(); const slow = hold(r, 's1');
|
||||
292| await vi.advanceTimersByTimeAsync(1100);
|
||||
293| expect(r.view()).toMatchObject({ phase: 'off', notice: WORDS.n…
|
||||
| ^
|
||||
294| await reopened(r, 1);
|
||||
295| slow.open(); await vi.advanceTimersByTimeAsync(0);
|
||||
|
||||
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[3/5]⎯
|
||||
|
||||
FAIL tests/voice.test.ts > a late end of an older call > starting again while the previous start still waits for the old room to be given back: only the newest call survives
|
||||
AssertionError: expected [ Room{ closed: +0, …(3) }, …(1) ] to deeply equal [ Room{ closed: +0, …(3) } ]
|
||||
|
||||
- Expected
|
||||
+ Received
|
||||
|
||||
@@ -14,6 +14,23 @@
|
||||
"ended": [Function anonymous],
|
||||
"stopped": 0,
|
||||
},
|
||||
],
|
||||
},
|
||||
+ Room {
|
||||
+ "closed": 0,
|
||||
+ "hushed": [],
|
||||
+ "on": {
|
||||
+ "agentJoined": [Function agentJoined],
|
||||
+ "agentState": [Function agentState],
|
||||
+ "audioBlocked": [Function audioBlocked],
|
||||
+ "dropped": [Function dropped],
|
||||
+ "subtitle": [Function subtitle],
|
||||
+ },
|
||||
+ "published": [
|
||||
+ Mic {
|
||||
+ "ended": [Function anonymous],
|
||||
+ "stopped": 0,
|
||||
+ },
|
||||
+ ],
|
||||
+ },
|
||||
]
|
||||
|
||||
❯ tests/voice.test.ts:316:58
|
||||
314| slow.open(); await Promise.all([b, c]); await flush(); // B w…
|
||||
315| const last = r.transport.rooms.length - 1;
|
||||
316| expect(r.transport.rooms.filter(x => !x.closed)).toEqual([r.tr…
|
||||
| ^
|
||||
317| expect(r.transport.mics.filter(m => !m.stopped)).toEqual([r.tr…
|
||||
318| expect(r.server.open.size).toBe(1);
|
||||
|
||||
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[4/5]⎯
|
||||
|
||||
@@ -0,0 +1,13 @@
|
||||
|
||||
> cybergril-web@0.1.0 build
|
||||
> tsc --noEmit && vite build
|
||||
|
||||
vite v6.3.6 building for production...
|
||||
transforming...
|
||||
✓ 57 modules transformed.
|
||||
rendering chunks...
|
||||
computing gzip size...
|
||||
dist/index.html 0.49 kB │ gzip: 0.35 kB
|
||||
dist/assets/index-BpZaybfD.css 83.54 kB │ gzip: 17.53 kB
|
||||
dist/assets/index-BzbZ2t4t.js 306.87 kB │ gzip: 102.13 kB
|
||||
✓ built in 620ms
|
||||
@@ -0,0 +1,10 @@
|
||||
|
||||
> cybergril-web@0.1.0 lint
|
||||
> eslint src
|
||||
|
||||
|
||||
/home/xiaomo/multica_workspaces/hello-af23464d222e/hel-897-cfe565d5b1bd/workdir/CyberGril/web/src/chat/ChatPanel.tsx
|
||||
222:100 warning The ref value 'fullButton.current' will likely have changed by the time this effect cleanup function runs. If this ref points to a node rendered by React, copy 'fullButton.current' to a variable inside the effect, and use that variable in the cleanup function react-hooks/exhaustive-deps
|
||||
|
||||
✖ 1 problem (0 errors, 1 warning)
|
||||
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/main --handoff docs/requirements/handoff-HEL-878.json
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/main --handoff docs/requirements/handoff-HEL-897.json
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/main
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/hel-870-assembly --handoff docs/requirements/handoff-HEL-878.json
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/hel-870-assembly --handoff docs/requirements/handoff-HEL-897.json
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/hel-870-assembly
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/agent/2/6a08a4c18f23 --handoff docs/requirements/handoff-HEL-878.json
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/agent/2/6a08a4c18f23 --handoff docs/requirements/handoff-HEL-897.json
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/agent/2/6a08a4c18f23
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/hel-878-voice-wiring --handoff docs/requirements/handoff-HEL-878.json
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/hel-878-voice-wiring --handoff docs/requirements/handoff-HEL-897.json
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,2 @@
|
||||
python3 scripts/check_requirements.py --base-ref origin/hel-878-voice-wiring
|
||||
需求结构检查通过:60项;来源和覆盖完整。仍须人工核对授权语义与实际体验。
|
||||
@@ -0,0 +1,4 @@
|
||||
|
||||
> cybergril-web@0.1.0 typecheck
|
||||
> tsc --noEmit
|
||||
|
||||
@@ -0,0 +1,21 @@
|
||||
|
||||
> cybergril-web@0.1.0 test
|
||||
> vitest run
|
||||
|
||||
|
||||
RUN v3.1.2 /home/xiaomo/multica_workspaces/hello-af23464d222e/hel-897-cfe565d5b1bd/workdir/CyberGril/web
|
||||
|
||||
✓ tests/r3memory.test.ts (5 tests) 7ms
|
||||
✓ tests/review878_late_cleanup.test.ts (1 test) 5ms
|
||||
✓ tests/real.test.ts (3 tests) 11ms
|
||||
✓ tests/domain.test.ts (12 tests) 9ms
|
||||
✓ tests/inbox.test.ts (13 tests) 24ms
|
||||
✓ tests/r2wiring.test.ts (11 tests) 27ms
|
||||
✓ tests/reading.test.ts (11 tests) 34ms
|
||||
✓ tests/voice.test.ts (32 tests) 51ms
|
||||
|
||||
Test Files 8 passed (8)
|
||||
Tests 88 passed (88)
|
||||
Start at 02:51:00
|
||||
Duration 305ms (transform 533ms, setup 0ms, collect 875ms, tests 168ms, environment 1ms, prepare 331ms)
|
||||
|
||||
Reference in New Issue
Block a user