fix(release): keep the launched package name when comparing plugin manifests
The version-only comparison blanked the whole launch argument, so a release that swapped rea-agents for another package passed the notes check as a version bump. Mask only the version after the last "@" and test a changed package name. The plugin readiness command in the installation guide now uses the pinned release version, so its report describes the server the plugin starts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
2da5e86289
commit
2fb79a99c8
@@ -782,12 +782,19 @@ plugin-only install `rea doctor --client <id>` and `rea doctor --skill` report
|
||||
`missing` and recommend `rea setup`. Do not follow that remediation. Check the
|
||||
plugin with the client instead (`claude plugin list` and `/mcp` in Claude
|
||||
Code, `codex plugin list` in Codex). A plugin does not put `rea` on your
|
||||
`PATH`, so check analysis engines through the package runner:
|
||||
`PATH`, so check analysis engines through the package runner, at the version
|
||||
the plugin pins so the report describes the server it starts:
|
||||
|
||||
<!-- x-release-please-start-version -->
|
||||
|
||||
```bash
|
||||
npx -y rea-agents@latest doctor --provider ghidra --json
|
||||
npx -y rea-agents@6.4.0 doctor --provider ghidra --json
|
||||
```
|
||||
|
||||
<!-- x-release-please-end -->
|
||||
|
||||
If your installed plugin is older, use the version in its manifest instead.
|
||||
|
||||
## MCP Registry
|
||||
|
||||
REA is published in the official MCP Registry as `io.github.morluto/rea`. Registry
|
||||
|
||||
@@ -376,7 +376,10 @@ function pluginManifestWithoutVersions(text) {
|
||||
if (manifest === null || typeof manifest !== "object") return text;
|
||||
if ("version" in manifest) manifest.version = "";
|
||||
const launch = manifest.mcpServers?.rea?.args;
|
||||
if (Array.isArray(launch) && launch.length > 1) launch[1] = "";
|
||||
// Only the version after the last "@" is release-owned; a different package
|
||||
// name changes what the plugin runs.
|
||||
if (Array.isArray(launch) && typeof launch[1] === "string")
|
||||
launch[1] = launch[1].replace(/@[^@/]*$/u, "@");
|
||||
return JSON.stringify(manifest);
|
||||
}
|
||||
|
||||
|
||||
@@ -48,10 +48,13 @@ const pluginManifests = [
|
||||
".codex-plugin/plugin.json",
|
||||
] as const;
|
||||
|
||||
const pluginManifest = (version: string, skills = ["./skill"]) => ({
|
||||
const pluginManifest = (
|
||||
version: string,
|
||||
{ skills = ["./skill"], packageName = "rea-agents" } = {},
|
||||
) => ({
|
||||
version,
|
||||
skills,
|
||||
mcpServers: { rea: { args: ["-y", `rea-agents@${version}`, "mcp"] } },
|
||||
mcpServers: { rea: { args: ["-y", `${packageName}@${version}`, "mcp"] } },
|
||||
});
|
||||
|
||||
beforeAll(async () => {
|
||||
@@ -415,13 +418,22 @@ it("binds publication to complete recorded history and the reviewed base", async
|
||||
});
|
||||
});
|
||||
|
||||
it.each(pluginManifests)(
|
||||
"treats a release that changes plugin behavior in %s as a product change",
|
||||
async (path) => {
|
||||
it.each(
|
||||
pluginManifests.flatMap((path) => [
|
||||
{ path, change: "the skill path", edit: { skills: ["./another-skill"] } },
|
||||
{
|
||||
path,
|
||||
change: "the launched package",
|
||||
edit: { packageName: "another-package" },
|
||||
},
|
||||
]),
|
||||
)(
|
||||
"treats a release that changes $change in $path as a product change",
|
||||
async ({ path, edit }) => {
|
||||
const f = await fixture();
|
||||
await writeFile(
|
||||
join(f.directory, path),
|
||||
JSON.stringify(pluginManifest("6.4.0", ["./another-skill"])),
|
||||
JSON.stringify(pluginManifest("6.4.0", edit)),
|
||||
);
|
||||
await git(f.directory, ["add", "CHANGELOG.md", path]);
|
||||
await git(f.directory, ["commit", "-m", "chore: release notes"]);
|
||||
|
||||
Reference in New Issue
Block a user