test(cli): type the retained skill directory pairs

noUncheckedIndexedAccess treats the unlabeled pair list as an open array, so the directory passed to join was string or undefined.

src/application/SupportedClients.ts

@@ -539,7 +539,7 @@ export const SUPPORTED_CLIENT_DEFINITIONS = [
     configPath: ({ home, platform, env }: ClientPathContext) =>
       join(devinDirectory({ home, platform, env }), "mcp_config.json"),
     markerPath: devinDirectory,
-    format: "devin",
+    format: "json",
   },
   {
     name: "opencode",

tests/boundary/cli/clientProfileLifecycle.test.ts

@@ -287,10 +287,11 @@ cliTest("uninstall names each retained skill directory", async ({ cli }) => {
   };
   const skill = report.items?.find(({ name }) => name === "skill");
   expect(skill?.status).toBe("retained");
-  for (const [client, directory] of [
+  const retainedDirectories = [
     ["shared", shared],
     ["claude_code", claude],
-  ]) {
+  ] as const;
+  for (const [client, directory] of retainedDirectories) {
     expect(skill?.detail).toContain(
       `${client} (${directory}): retained (Skill manifest is not REA-owned.)`,
     );

tests/boundary/mcp/ghidraInventoryMcp.test.ts

@@ -14,7 +14,6 @@ import {
 } from "./ghidraMcpHarness.js";
 import { spawn } from "node:child_process";
 import { mkdir } from "node:fs/promises";
-import { join } from "node:path";
 import { fileURLToPath } from "node:url";
 import { Client, InMemoryTransport } from "@modelcontextprotocol/client";
 import { GhidraClient } from "../../../src/ghidra/GhidraClient.js";