Files
rea/tests/boundary/filesystem/cliJsonInput.test.ts
T
You WishandGitHub 5f16124a31 fix(files): reject nonregular capture and JSON inputs
Verify selected files through a nonblocking opened handle before reading. Preserve regular-file symlinks and return actionable CLI/MCP diagnostics without publishing output.

Co-authored-by: YouWish <29498139+Y0UW1SH@users.noreply.github.com>
2026-10-10 01:49:54 +08:00

180 lines
5.8 KiB
TypeScript

import { execFile } from "node:child_process";
import { chmod, symlink, writeFile } from "node:fs/promises";
import { join } from "node:path";
import { promisify } from "node:util";
import { describe, expect, it, onTestFinished } from "vitest";
import { parseCliJsonInput } from "../../../src/cliJsonInput.js";
import { readWithoutFifoWriter } from "../../fixtures/fifoInput.js";
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
describe("CLI JSON file selection", () => {
it("accepts a symlink to a regular JSON file", async () => {
const root = await createTestTempDirectory("rea-json-input-symlink-");
const path = join(root, "input.json");
const selected = join(root, "selected.json");
await writeFile(path, '{"value":1}');
await symlink(path, selected, "file");
expect(await parseCliJsonInput(selected, "test-input")).toEqual({
ok: true,
value: { value: 1 },
});
});
it
.skipIf(process.platform === "win32")
.each(["a named pipe", "a symlink to a named pipe"])(
"rejects %s without waiting for a writer",
async (kind) => {
const root = await createTestTempDirectory("rea-json-input-fifo-");
const fifoPath = join(root, "input.pipe");
await promisify(execFile)("mkfifo", [fifoPath]);
const selected =
kind === "a named pipe" ? fifoPath : join(root, "selected.json");
if (selected !== fifoPath) await symlink(fifoPath, selected, "file");
const outcome = await readWithoutFifoWriter(fifoPath, () =>
parseCliJsonInput(selected, "test-input"),
);
expect(outcome.state).toBe("completed");
if (outcome.state !== "completed")
throw new Error("JSON read waited for a FIFO writer");
expect(outcome.result).toMatchObject({
ok: false,
error: {
code: "invalid_request",
input_path: selected,
input_reason: "read-failed",
details: {
issues: [
{
path: [],
reason: "invalid_value",
message: expect.stringContaining("(ENOTFILE)"),
},
],
},
},
});
},
);
it.skipIf(process.platform === "win32")(
"rejects a character device before parsing JSON bytes",
async () => {
expect(await parseCliJsonInput("/dev/null", "test-input")).toMatchObject({
ok: false,
error: {
code: "invalid_request",
input_path: "/dev/null",
input_reason: "read-failed",
details: {
issues: [
{
path: [],
reason: "invalid_value",
message: expect.stringContaining("(ENOTFILE)"),
},
],
},
},
});
},
);
});
describe("CLI JSON input", () => {
it("distinguishes malformed inline text from files and preserves bracket-prefixed paths", async () => {
expect(await parseCliJsonInput("[", "test-input")).toMatchObject({
ok: false,
error: {
details: { issues: [{ reason: "invalid_format", expected: "JSON" }] },
},
});
expect(await parseCliJsonInput("[", "test-input")).toMatchObject({
ok: false,
error: {
details: { issues: [{ reason: "invalid_format", expected: "JSON" }] },
},
});
const root = await createTestTempDirectory("rea-json-input-");
const path = join(root, "input.json");
await writeFile(path, '{"value":1}');
expect(await parseCliJsonInput(path, "test-input")).toEqual({
ok: true,
value: { value: 1 },
});
expect(await parseCliJsonInput("false", "test-input")).toEqual({
ok: true,
value: false,
});
const bracketPath = join(root, "[input].json");
await writeFile(bracketPath, '["preserved"]');
expect(await parseCliJsonInput(bracketPath, "test-input")).toEqual({
ok: true,
value: ["preserved"],
});
for (const missingPath of [
join(root, "{capture}.json"),
join(root, "[missing].json"),
])
expect(await parseCliJsonInput(missingPath, "test-input")).toMatchObject({
ok: false,
error: { input_path: missingPath, input_reason: "read-failed" },
});
expect(await parseCliJsonInput(root, "test-input")).toMatchObject({
ok: false,
error: { input_reason: "read-failed" },
});
});
it.each([
["a missing file", "ENOENT"],
["a directory", "EISDIR"],
] as const)(
"lists the system cause when %s cannot be read",
async (kind, code) => {
const root = await createTestTempDirectory("rea-json-input-cause-");
const path = kind === "a directory" ? root : join(root, "missing.json");
expect(await parseCliJsonInput(path, "test-input")).toMatchObject({
ok: false,
error: {
code: "invalid_request",
input_path: path,
input_reason: "read-failed",
details: {
issues: [
{
path: [],
reason: "invalid_value",
message: `The JSON input file could not be read (${code}): ${path}`,
},
],
},
},
});
},
);
it.skipIf(process.platform === "win32" || process.getuid?.() === 0)(
"lists a permission denial as the cause of an unreadable file",
async () => {
const root = await createTestTempDirectory("rea-json-input-denied-");
const path = join(root, "input.json");
await writeFile(path, "{}");
await chmod(path, 0o000);
onTestFinished(() => chmod(path, 0o600));
expect(await parseCliJsonInput(path, "test-input")).toMatchObject({
ok: false,
error: {
input_reason: "read-failed",
details: {
issues: [{ message: expect.stringContaining("(EACCES)") }],
},
},
});
},
);
});